rust

rust copied to clipboard

Does Url::origin leak?

5

In [Url origin](https://github.com/ada-url/rust/blob/7cd8574cb01ed38b0b246fcf2c71d826efb0530d/src/lib.rs#L273), [ffi::ada_get_origin](https://github.com/ada-url/rust/blob/7cd8574cb01ed38b0b246fcf2c71d826efb0530d/src/ffi.rs#L75) is called Within the C++ code, ada_get_origin allocates an [ada_owned_string](https://github.com/ada-url/rust/blob/7cd8574cb01ed38b0b246fcf2c71d826efb0530d/src/ffi.rs#L27) using [new[]](https://github.com/ada-url/ada/blob/e356ab9e8184ba1bb15a0d78a6c3af9a3e402761/src/ada_c.cpp#L122) It is supposed to be freed using [ada_free_owned_string](https://github.com/ada-url/ada/blob/e356ab9e8184ba1bb15a0d78a6c3af9a3e402761/src/ada_c.cpp#L127). However, the call to the function...

pratikpc

Profile-Guided Optimization (PGO) benchmark result

1

Hi! I do ongoing PGO research on different applications - all results are available at https://github.com/zamazan4ik/awesome-pgo . I performed some PGO benchmarks on the `ada-url` library and want to share...

zamazan4ik

Work in-progress.

anonrig

It would be nice to compare `idna` package with `ada_url::idna` and have a benchmark in our readme.

anonrig

Add some unsafe magic for minimal optimizations, add .idea to .gitignore and fix some typos

3

Thanks for the amazing contribution to open source url parsing! I am using this lib right now and thought that I should look into it a bit, I ended up...

Kleinmarb

adding cargo-semver-checks

3

@obi1kenobi 's cargo-semver-checks would likely improve our stability. let's use it! https://github.com/obi1kenobi/cargo-semver-checks

anonrig