qlever Make operations aware whether the sorting they provide is required

Make operations aware whether the sorting they provide is required

Open joka921 opened this issue 1 year ago • 2 comments

Some operations like merge joins on sorted inputs automatically create a sorted result and also announce this sorting in their interface. Make such operations aware whether this sorting is actually required by the parent operation. If this is not the case, they can also resort to a cheaper implementation that doesn't provide the sorting (for example a hash join on unsorted input)

Mar 29 '23 08:03 joka921

Codecov Report

Patch coverage: 60.16% and project coverage change: +0.02 :tada:

Comparison is base (e3060fc) 72.58% compared to head (975480b) 72.61%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
+ Coverage   72.58%   72.61%   +0.02%     
==========================================
  Files         250      250              
  Lines       24247    24229      -18     
  Branches     3085     3083       -2     
==========================================
- Hits        17600    17593       -7     
+ Misses       5375     5369       -6     
+ Partials     1272     1267       -5

Impacted Files	Coverage Δ
src/engine/QueryExecutionTree.h	`60.00% <ø> (ø)`
src/engine/QueryPlanner.h	`60.00% <ø> (ø)`
src/engine/TextOperationWithFilter.cpp	`55.55% <0.00%> (ø)`
src/engine/TextOperationWithFilter.h	`73.91% <0.00%> (ø)`
src/engine/TextOperationWithoutFilter.cpp	`69.72% <0.00%> (ø)`
src/engine/TextOperationWithoutFilter.h	`89.47% <0.00%> (ø)`
src/engine/TransitivePath.cpp	`24.23% <0.00%> (ø)`
src/engine/IndexScan.cpp	`72.11% <54.54%> (+0.48%)`	:arrow_up:
src/engine/Join.cpp	`76.32% <62.50%> (ø)`
src/engine/Operation.cpp	`53.17% <74.46%> (ø)`
... and 8 more