qlever icon indicating copy to clipboard operation
qlever copied to clipboard

Published 20 hours ago • verified publisher icon ad-freiburg

Changes to make the fast CTRE index builder work for OSM (do not merge)

Open hannahbast opened this issue 3 years ago • 0 comments

This PR should not be merged into the master as is because some of it is ad-hoc (items 1 and 4) and some of it is just congifuration (item 3). Here is what it does:

  1. Assume that all triples are subject-predicate-object (no , or ; syntax to avoid repeating the subject and/or predicate) and that all triples are on a single line and end with a newline.

  2. In the current master, all literals with ^^ after the last quote are considered as xsd values, which cannot be externalized. In particular, this prevents the externalization of literals of type ^^geo:wktLiteral . This could be considered a BUG in the current master, which is fixed by a change in this PR.

  3. Externalize all literals of length > 128 (so far the threshold was 1024). This will externalize all larger geometries, but not POINTs and simple geometries like buildings. This should actually be configurable in the settings.json.

  4. Don't run the TurtleParserTest because it has several tests concerning the escaping of , and ; which now fail due to 1.

hannahbast avatar May 14 '21 18:05 hannahbast