pkgbuilds icon indicating copy to clipboard operation
pkgbuilds copied to clipboard

[python-hydra-core] uses antlr 4.9.3 while python-antlr4 is 4.11.1-1

Open 4rozenwolves opened this issue 3 years ago • 4 comments

Hydra uses an internal antlr.

This makes it not compatible with antlr installed in the system. One solution is to replace the internal antlr to use system antlr, as done in python-omegaconf.

4rozenwolves avatar Oct 19 '22 12:10 4rozenwolves

I added the following code in the pkgbuild:

prepare() {
  cd "${srcdir}/${_pkgname}-${pkgver}"
  sed -i 's/join(root_dir, "bin\/antlr-4.9.3-complete.jar")/"\/usr\/share\/java\/antlr-complete.jar"/' 'build_helpers/build_helpers.py'
}

4rozenwolves avatar Oct 25 '22 09:10 4rozenwolves

Personally, I believe that if upstream wants to use their own packaged antlr4, then as packagers we should respect that (assuming that there are no other issues due to that decision). If someone could make an upstream issue that requests the option to use system installed antlr4 then we can get the reception of upstream to see if they would be open to that.

acxz avatar Feb 22 '23 16:02 acxz

patched with #223

acxz avatar Feb 22 '23 17:02 acxz

keeping this open until the patch is no longer needed

acxz avatar Mar 28 '23 20:03 acxz