Ryan Henning

Results 19 comments of Ryan Henning
trafficstars

If you use the new [pubsub.py](https://github.com/django/channels_redis/blob/main/channels_redis/pubsub.py) implementation, then `group_send` is much easier to understand. Worth consideration -- it just uses Redis pub/sub so it should be easy to publish messages...

To solve this problem, I started using Uvicorn & Gunicorn (those names make me laugh every time I write them...). Gunicorn can deploy your new code by spinning up new...

Yeah it will drop websocket connections, but any "normal" HTTP connections *should* be drained gracefully before the old workers are shut down (I haven't tested it super-well, but it does...

@andrewgodwin Thank you for working so hard to build channels! Btw, channels 2 is wonderful. All the changes are **well worth** breaking the interface from channels 1. It's great to...

@fosterseth Thanks for investigating this. Your discoveries got me thinking, and now I have some ideas on what is going wrong here. ### First, some context: The giant comment I...

> @acu192 Would you like to investigate making that change in django/channels? Yes, I'll put some time on my calendar in the next few weeks to create a PR to...

See my other comment I just made: https://github.com/django/channels/pull/1948#issuecomment-1312165651 I _do_ have permissions in this repo, so I ran the workflows for you. My only comment is to update or delete...

Cross linking https://github.com/django/channels/pull/1948 which is a long-standing known memory leak in channels.

Good work on this. These race conditions are certainly hard to think about, but I agree with your analysis. This solution looks good to me! [It is similar what I've...