celery.node icon indicating copy to clipboard operation
celery.node copied to clipboard

remove result output in succeded tasks

Open danielmichalichyn opened this issue 4 years ago • 2 comments

Description

In this pull request I'm suggesting that we remove the result output when a task is succeded. If we need to print the result when a task is finished, we can do a console.info/.log from the task. Printing the result from the celery.node package, can create issues if we have a huge result output, and when we run this application in a Docker the container logs get flooded with a lot of useless information.

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Removing the result variable from a console.info.

  • What is the current behavior? (You can also link to an open issue here) Print all the result into the console of the application;

  • What is the new behavior (if this is a feature change)? Print only conclusion information about the task;

danielmichalichyn avatar May 24 '21 14:05 danielmichalichyn

Hi, @danielmichalichyn! Always greatly appreciated this awesome PR!

But in this case, I'm not sure it is really required for us. We should hear other user's voices.

actumn avatar May 27 '21 15:05 actumn

Hi @actumn , I believe @danielmichalichyn is right. If the worker's function is handling personal sensitive information (ie: tax id, Social Security number etc...), you don't want to have them logged and potentially available for other teams/people to see (es: sys admin, ops team, etc...). Maybe, instead of removing the result variable for all worker's functions, it can be handled with an optional parameter to add when a function is registered into a worker.

bitcranos avatar Jun 10 '23 10:06 bitcranos