Update magsafe if it's the wrong color

[Fizzadar]

Quick fix to update the magsafe color if it's wrong (it seems to reset to orange if you replug it whilst above the threshold).

Closes: #172

[ibrado]

Seems to be the same as my PR #184 ..?

[actuallymentor]

Hey @ibrado and @Fizzadar!

Thank you both for catching this, I appreciate that both of you saw an issue and immediately went into "imma fix this" mode.

Given both your PRs (this #201, and #184), which approach do you both feel is the best? Your code uses slightly different approaches and I'd like to merge one of them (and express gratitude to you both).

[ibrado]

Hi Mentor (and Fizzador),

Fizzadar's code is more straightforward and appears to handle things properly, so I have no problem with his PR being merged instead of mine. :-)

I seem to remember working around some odd behavior (some combination of force-discharging, clamshell, and/or charging while asleep, I think) which is why I used "AC is attached", but I can't replicate it. If I ever I do, I'll file a ticket. :-P

Thanks and regards, Alex

On Wed, Jan 17, 2024 at 6:41 PM Mentor Palokaj @.***> wrote:

Hey @ibrado https://github.com/ibrado and @Fizzadar https://github.com/Fizzadar!

Thank you both for catching this, I appreciate that both of you saw an issue and immediately went into "imma fix this" mode.

Given both your PRs (this #201 https://github.com/actuallymentor/battery/pull/201, and #184 https://github.com/actuallymentor/battery/pull/184), which approach do you both feel is the best? Your code uses slightly different approaches and I'd like to merge one of them (and express gratitude to you both).

— Reply to this email directly, view it on GitHub https://github.com/actuallymentor/battery/pull/201#issuecomment-1895542521, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZIUUNTGTEE25STEQTSXFDYO6TGHAVCNFSM6AAAAAA7YH3IZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVGU2DENJSGE . You are receiving this because you were mentioned.Message ID: @.***>

[bmarkkkkk]

yes, also having this issue. if it reached it's target, but you unplug, then re-plug... color goes to orange. there are a couple PR's on this.

[Fizzadar]

Hi @actuallymentor (& Ibrado) - totally happy with either PR. I think there was a reason I didn't use the other but again I don't recall either, definitely a edge case situation.

[bmarkkkkk]

did this get merged?

[actuallymentor]

Ended up merging the other one (because I forgot our convo here). Closing this with gratitude to you both!