[WIP] hide target category from cover overspending list

[matt-fidd]

When using the cover overspending menu, it allows you to select the target category as the cover source. This doesn't cause a problem but doesn't make much sense or do anything.

[netlify[bot]]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	fb8ee3392c1f6a28f439539cfbc3ba0e2b67325b
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66bcfd2fe6b4d600088b120f
😎 Deploy Preview	https://deploy-preview-3115.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions[bot]]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.94 MB → 4.94 MB (+1023 B)	+0.02%

Changeset

File	Δ	Size
src/components/budget/rollover/CoverMenu.tsx	📈 +442 B (+25.50%)	1.69 kB → 2.12 kB
src/components/modals/CoverModal.tsx	📈 +484 B (+17.07%)	2.77 kB → 3.24 kB
src/components/budget/rollover/BalanceMovementMenu.tsx	📈 +30 B (+2.15%)	1.36 kB → 1.39 kB
src/components/Modals.tsx	📈 +38 B (+0.26%)	14.09 kB → 14.13 kB
src/components/mobile/budget/BudgetTable.jsx	📈 +29 B (+0.06%)	50.44 kB → 50.47 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	3.22 MB → 3.22 MB (+994 B)	+0.03%
static/js/narrow.js	77.55 kB → 77.58 kB (+29 B)	+0.04%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	27.55 kB	0%
static/js/usePreviewTransactions.js	790 B	0%
static/js/wide.js	241.46 kB	0%
static/js/ReportRouter.js	1.24 MB	0%

[github-actions[bot]]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.14 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.14 MB	0%

[joel-jeremy]

Thank you! Can we also apply this on the mobile category autocomplete modal?

I just also realized that it doesn't make sense to show categories with zero or negative balances on the cover category selection. But that's out of scope of this PR.

[matt-fidd]

@joel-jeremy where do I need to make the mobile changes please? I've dug about and I can't seem to find it, although I can see that on mobile it's different.

[joel-jeremy]

@matt-fidd It starts in the CoverModal which opens up the CategoryAutocompleteModal

[github-actions[bot]]

:wave: Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

[matt-fidd]

Phew that took a while!

@joel-jeremy - change now works on mobile too

[jfdoming]

Looks good! I'm thinking the same change would be good when performing a budget transfer (same menu option when a category is not overspent). Future PR?

[matt-fidd]

@jfdoming good shout! Now I know my way round this bit of the code base I'll handle your suggestion and earlier ones from joel-jeremy in a seperate PR.