[Bug]: Upcoming date on schedules preview can show dates prior to "From" selected

[bvanelli]

Verified issue does not already exist?

• [X] I have searched and found no existing issue
• [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Here is the description of the bug, and how to reproduce it via frontend:

• The "From" field is set to 11/05/2024 but
• The "Upcoming dates" show 10/05/2024

The issue happens because the comparison is done with the 2nd Saturday of the Month (11/05), and since that is greater or equal the "From" field of 11/05, the date is allowed through, BUT, because it's weekend, the schedule property shifts it one day before, making it occour in the past.

This is only relevant for this specific shiting (weekendSolveMode=before) because it's the only way the date can be shifted backwards, at least from my testing.

I got in contact with some developers on Discord to check if this is expected behaviour or not before opening the issue, but I think a bit more discussion is needed since it wasn't a consensus. To me at least seems like undesired behaviour.

I'm using Actual 24.5.0, but I haven't tried with main to check if it's solved on the main branch.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Mac OSX