actual
actual copied to clipboard
actualbudget
Don't update transaction date when importing manually
Following work done in #1559 and update in #2534 (discussion https://github.com/actualbudget/actual/pull/2534#discussion_r1545649961), I think manual import should not override the transaction date as is done with bank account sync.
Deploy Preview for actualbudget ready!
| Name | Link |
|---|---|
| Latest commit | af5d00168ef83d83bdb2553e887aaeedf70a749f |
| Latest deploy log | https://app.netlify.com/sites/actualbudget/deploys/6636960305296d000801bcfe |
| Deploy Preview | https://deploy-preview-2648.demo.actualbudget.org |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bundle Stats — desktop-client
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
| Files count | Total bundle size | % Changed |
|---|---|---|
| 9 | 4.7 MB | 0% |
Changeset
No files were changed
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
| Asset | File Size | % Changed |
|---|---|---|
| static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% |
| static/js/resize-observer.js | 18.37 kB | 0% |
| static/js/BackgroundImage.js | 122.29 kB | 0% |
| static/js/narrow.js | 59.7 kB | 0% |
| static/js/usePreviewTransactions.js | 790 B | 0% |
| static/js/AppliedFilters.js | 20.41 kB | 0% |
| static/js/wide.js | 263.53 kB | 0% |
| static/js/ReportRouter.js | 1.22 MB | 0% |
| static/js/index.js | 2.99 MB | 0% |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bundle Stats — loot-core
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
| Files count | Total bundle size | % Changed |
|---|---|---|
| 1 | 1.2 MB → 1.2 MB (-22 B) | -0.00% |
Changeset
| File | Δ | Size |
|---|---|---|
packages/loot-core/src/server/accounts/sync.ts |
📉 -102 B (-0.45%) | 22.13 kB → 22.04 kB |
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
| Asset | File Size | % Changed |
|---|---|---|
| kcab.worker.js | 1.2 MB → 1.2 MB (-22 B) | -0.00% |
Unchanged
No assets were unchanged
@Wizmaster what do you think about making this conditional on the cleared status?
That way uncleared items still get updated with the import, but you can manually edit dates for imported records and they won't be overwritten on further imports?
@twk3 I think that if a transaction exists before import (manual or bank sync), the inputted date should be kept. I know that sometimes banks can use a later date due to batched transactions not always sent in time, it would be better to always keep the date the end-user inputted.
@MatissJanis 👍
I cant think of a reason to have bank sync act differently than a file import. In theory they should be the same, just one is automated. Ill merge this is for now and we will see if any edge users complain about the change.
