actual
actual copied to clipboard
actualbudget
[WIP] Unflag custom reports
Deploy Preview for actualbudget ready!
| Name | Link |
|---|---|
| Latest commit | ddc08500354661a826ec94c964999a94c3a3a09f |
| Latest deploy log | https://app.netlify.com/sites/actualbudget/deploys/66720ee54b8ccf0008b08c0f |
| Deploy Preview | https://deploy-preview-2554.demo.actualbudget.org |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bundle Stats — desktop-client
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
| Files count | Total bundle size | % Changed |
|---|---|---|
| 9 | 4.75 MB → 4.75 MB (-293 B) | -0.01% |
Changeset
| File | Δ | Size |
|---|---|---|
src/components/settings/Experimental.tsx |
📉 -145 B (-4.42%) | 3.21 kB → 3.06 kB |
src/hooks/useFeatureFlag.ts |
📉 -24 B (-5.90%) | 407 B → 383 B |
src/components/reports/Overview.tsx |
📉 -124 B (-6.19%) | 1.96 kB → 1.83 kB |
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
| Asset | File Size | % Changed |
|---|---|---|
| static/js/index.js | 3.02 MB → 3.02 MB (-169 B) | -0.01% |
| static/js/ReportRouter.js | 1.23 MB → 1.23 MB (-124 B) | -0.01% |
Unchanged
| Asset | File Size | % Changed |
|---|---|---|
| static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% |
| static/js/BackgroundImage.js | 122.29 kB | 0% |
| static/js/resize-observer.js | 18.37 kB | 0% |
| static/js/narrow.js | 75.73 kB | 0% |
| static/js/usePreviewTransactions.js | 790 B | 0% |
| static/js/AppliedFilters.js | 20.25 kB | 0% |
| static/js/wide.js | 263.59 kB | 0% |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bundle Stats — loot-core
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
| Files count | Total bundle size | % Changed |
|---|---|---|
| 1 | 1.13 MB | 0% |
Changeset
No files were changed
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
| Asset | File Size | % Changed |
|---|---|---|
| kcab.worker.js | 1.13 MB | 0% |
I think I'm ready to remove custom reports from experimental. It's fairly stable at this point. It has most everything I planned to add to it. Still plenty more to add and a couple things to fix but I don't think they are big issues that should stop it from going "live". Please share your thoughts.
I think my main hangup would be that live date ranges don't update for dashboard cards without going in and updating the report. Its not a big deal since work will still go on.
I think my main hangup would be that live date ranges don't update for dashboard cards without going in and updating the report. Its not a big deal since work will still go on.
Yea, it's at the top of my list right now. I'll try to put in a PR this weekend to fix that.
I'd recommend not rushing into this prematurely. The feature still seems quite unstable (judging from the amount of bug reports coming in). Could we hold off a bit more to gather some more feedback before calling it a stable feature?
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
I'd recommend not rushing into this prematurely. The feature still seems quite unstable (judging from the amount of bug reports coming in). Could we hold off a bit more to gather some more feedback before calling it a stable feature?
Heya, I know this comment is 2 months old but the bug reports you mention were very small issues that were directly related to newer features and were fixed quite easily. The only reason I said stable is that we've gone several months without any major issues with the feature.
Fast forward to today - since opening this PR, I've requested feedback on the stability of the feature and fixed all (very minor, most visual) issues reported. I've also converted 100% of the code to strict TS and submitted several code hardening PRs to make this feature ready for release.
If there are any further concerns I'm happy to address them. I am currently very confident in propsing this feature is removed from experimental for the next release (v24.7).
Are you wanting to unflag even without the net additions?
I don't see the changes to net as a blocker for this PR. I see the net additions as a good enhancement but not imperitive for release. I'm also happy to discuss this view if anyone disagrees.