actual icon indicating copy to clipboard operation
actual copied to clipboard

Convert SavedFilters to Typescript

Open carkom opened this issue 1 year ago • 3 comments

Split out all the elements into separate files - working to get rid of mega-files in the code base. Updated all those files to Typescript.

carkom avatar Feb 02 '24 20:02 carkom

Deploy Preview for actualbudget ready!

Name Link
Latest commit 1934642aefa8fbf91868ee143363e75e6bd64a73
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65cb3bc7a1570d0008631348
Deploy Preview https://deploy-preview-2320.demo.actualbudget.org/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 02 '24 20:02 netlify[bot]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.44 MB → 4.44 MB (-55 B) -0.00%
Changeset
File Δ Size
src/components/filters/SavedFilterMenuButton.tsx 🆕 +4.42 kB 0 B → 4.42 kB
src/components/filters/NameFilter.tsx 🆕 +2.01 kB 0 B → 2.01 kB
src/components/filters/FilterMenu.tsx 🆕 +1.47 kB 0 B → 1.47 kB
src/components/filters/FiltersStack.tsx 🆕 +971 B 0 B → 971 B
src/components/filters/CondOpMenu.tsx 🆕 +700 B 0 B → 700 B
src/components/filters/SavedFilters.jsx 🔥 -9.58 kB (-100%) 9.58 kB → 0 B
View detailed bundle breakdown

Added

Asset File Size % Changed
static/js/MenuTooltip.js 0 B → 20 kB (+20 kB) -

Removed

Asset File Size % Changed
static/js/AppliedFilters.js 28.91 kB → 0 B (-28.91 kB) -100%

Bigger

Asset File Size % Changed
static/js/wide.js 258.43 kB → 267.28 kB (+8.85 kB) +3.42%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 79.83 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/ReportRouter.js 1.2 MB 0%
static/js/index.js 2.73 MB 0%

github-actions[bot] avatar Feb 02 '24 21:02 github-actions[bot]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

github-actions[bot] avatar Feb 02 '24 21:02 github-actions[bot]