actual icon indicating copy to clipboard operation
actual copied to clipboard

[Feature] Add ability to create schedules from existing transactions

Open xentara1 opened this issue 1 year ago • 12 comments

#2221 Please let me know thoughts, or if you need any additional information

xentara1 avatar Jan 13 '24 13:01 xentara1

Deploy Preview for actualbudget ready!

Name Link
Latest commit 9b23205c52fe28028b063a216b39386862c36f07
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65be7f07a067080008576267
Deploy Preview https://deploy-preview-2222.demo.actualbudget.org/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 13 '24 13:01 netlify[bot]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.99 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/AppliedFilters.js 28.99 kB 0%
static/js/narrow.js 80.18 kB 0%
static/js/wide.js 240.49 kB 0%
static/js/ReportRouter.js 1.84 MB 0%
static/js/index.js 2.65 MB 0%

github-actions[bot] avatar Jan 13 '24 13:01 github-actions[bot]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.18 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.18 MB 0%

github-actions[bot] avatar Jan 13 '24 13:01 github-actions[bot]

👋 Cool feature!

The list of all transaction options is getting quite long. Could you instead create a "create schedule" button in the "Link schedule" modal? That would solve the same problem (albeit with one more click, but I think that's fine since we don't expect people to be creating schedules often).

MatissJanis avatar Jan 13 '24 14:01 MatissJanis

Adjusted let me know thoughts.

xentara1 avatar Jan 13 '24 15:01 xentara1

Nice. I like that new placement of the button. We probably should add this to the docs in some way

youngcw avatar Jan 13 '24 15:01 youngcw

Fixed lint's, Not used typescript before so don't think its the best way hah.

xentara1 avatar Jan 13 '24 15:01 xentara1

Nice. I like that new placement of the button. We probably should add this to the docs in some way

Where do I update that?

xentara1 avatar Jan 13 '24 15:01 xentara1

Fixed lint's, Not used typescript before so don't think its the best way hah.

if you run yarn lint --fix most lint issues will get taken care of. It looks like your fixes are fine though

youngcw avatar Jan 13 '24 15:01 youngcw

Where do I update that?

There is a repo for the docs and website https://github.com/actualbudget/docs

youngcw avatar Jan 13 '24 16:01 youngcw

Where do I update that?

There is a repo for the docs and website https://github.com/actualbudget/docs

Added -> https://github.com/actualbudget/docs/pull/303

xentara1 avatar Jan 13 '24 17:01 xentara1

Nice! This looks much better. But I'm seeing some usability problems:

  • [ ] after creating the schedule - it should auto-update the selected transaction so it would be added to the new schedule
  • [ ] after creating the schedule - all modals should be closed

Would you mind taking a look at these small issues? Also: please run yarn lint --fix

Let me know if I/we can help!

MatissJanis avatar Jan 14 '24 16:01 MatissJanis

Makes sense, adjusted as per comments, Removed a check on event as don't see why it is a must, let me know if I'm missing something

xentara1 avatar Jan 15 '24 21:01 xentara1

Updated all comments, Let me know if you want me to resolve the conversation, not sure how it normally works for opensource, When code reviewing at work, it annoys me when someone else resolves everything without me confirming,

xentara1 avatar Jan 17 '24 15:01 xentara1