actual
actual copied to clipboard
actualbudget
fixed:issue->#1968 Import from nYNAB fails with unknown error
Allow case insensitive ynab5 import for special 'starting balance' payee
Fixes issue for attached budget in this https://github.com/actualbudget/actual/issues/1968#issuecomment-1880111861 by allow case insensitive search for starting balance.
Should address #1968 as described in this comment https://github.com/actualbudget/actual/issues/1968#issuecomment-1880192146
Deploy Preview for actualbudget ready!
| Name | Link |
|---|---|
| Latest commit | 9740a1a4ed817c088c99d92a14b2a9c8f7026ac5 |
| Latest deploy log | https://app.netlify.com/sites/actualbudget/deploys/65a1a32ff11e5c0008c77120 |
| Deploy Preview | https://deploy-preview-2191.demo.actualbudget.org/ |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bundle Stats — desktop-client
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
| Files count | Total bundle size | % Changed |
|---|---|---|
| 10 | 5.07 MB | 0% |
Changeset
No files were changed
View detailed bundle breakdown
Added
| Asset | File Size | % Changed |
|---|---|---|
| static/js/index-SWxeZUPc.js | 0 B → 2.63 MB (+2.63 MB) | - |
| static/js/ReportRouter-u-ECnBz-.js | 0 B → 1.94 MB (+1.94 MB) | - |
| static/js/wide-x6lt6lI8.js | 0 B → 236.3 kB (+236.3 kB) | - |
| static/js/BackgroundImage-J5Jegp-2.js | 0 B → 122.29 kB (+122.29 kB) | - |
| static/js/narrow-7Le0Ro4Y.js | 0 B → 82.17 kB (+82.17 kB) | - |
| static/js/FiltersMenu-n9COqW5C.js | 0 B → 28.92 kB (+28.92 kB) | - |
| static/js/BalanceTooltip-6vz3j6VD.js | 0 B → 6.07 kB (+6.07 kB) | - |
| static/js/ButtonLink-TvteIVx8.js | 0 B → 379 B (+379 B) | - |
Removed
| Asset | File Size | % Changed |
|---|---|---|
| static/js/index-J-HRzf7W.js | 2.63 MB → 0 B (-2.63 MB) | -100% |
| static/js/ReportRouter-kHvxuvO-.js | 1.94 MB → 0 B (-1.94 MB) | -100% |
| static/js/wide-igRhAA-f.js | 236.3 kB → 0 B (-236.3 kB) | -100% |
| static/js/BackgroundImage-V1jYm3hh.js | 122.29 kB → 0 B (-122.29 kB) | -100% |
| static/js/narrow-v240ErwI.js | 82.17 kB → 0 B (-82.17 kB) | -100% |
| static/js/FiltersMenu-4QE4ezd2.js | 28.92 kB → 0 B (-28.92 kB) | -100% |
| static/js/BalanceTooltip-MQNa0IKd.js | 6.07 kB → 0 B (-6.07 kB) | -100% |
| static/js/ButtonLink-X4dED4fm.js | 379 B → 0 B (-379 B) | -100% |
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
| Asset | File Size | % Changed |
|---|---|---|
| static/js/indexeddb-main-thread-worker-e59fee74-bhyX5Ad6.js | 13.5 kB | 0% |
| static/js/resize-observer-6FaCDon1.js | 18.37 kB | 0% |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bundle Stats — loot-core
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
| Files count | Total bundle size | % Changed |
|---|---|---|
| 1 | 1.23 MB → 1.23 MB (+43 B) | +0.00% |
Changeset
| File | Δ | Size |
|---|---|---|
packages/loot-core/src/server/importers/ynab5.ts |
📈 +321 B (+3.15%) | 9.96 kB → 10.28 kB |
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
| Asset | File Size | % Changed |
|---|---|---|
| kcab.worker.js | 1.23 MB → 1.23 MB (+43 B) | +0.00% |
Smaller
No assets were smaller
Unchanged
No assets were unchanged
Thanks! Would you be OK adding the same logic for the other category/payee matchers in the same file? Might as well fix it everywhere if we've gone so far.
👋 I have extracted the check and applied it to all the string literals in the file. Seems like it might be out of the scope for what we initially set out to change. Let me know what y'all think, can always drop the last couple of commits. Thanks.