Bugfix: Add Primary Button hover background colors for light and dark theme #1971

[Ife-Ody]

@carkom

[netlify[bot]]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	8940b249e2f8043000a04e7035d1c0dea1f8706f
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/65b3ea89ebd8660008587943
😎 Deploy Preview	https://deploy-preview-2123.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions[bot]]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	4.98 MB → 4.98 MB (-30 B)	-0.00%

Changeset

File	Δ	Size
src/style/themes/light.ts	📉 -14 B (-0.21%)	6.55 kB → 6.54 kB
src/style/themes/dark.ts	📉 -16 B (-0.22%)	6.95 kB → 6.94 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/index.js	2.64 MB → 2.64 MB (-30 B)	-0.00%

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/ButtonLink.js	379 B	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	81.81 kB	0%
static/js/BalanceTooltip.js	6.06 kB	0%
static/js/FiltersMenu.js	28.92 kB	0%
static/js/wide.js	239.61 kB	0%
static/js/ReportRouter.js	1.84 MB	0%

[github-actions[bot]]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.18 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.18 MB	0%

[carkom]

It seems most button hovers use 2 shades of difference. Can we try that? Also, can you do the normal text hover? It has something for dark theme but not on light.

Might be a good opportunity to fix #2090 in this PR as well?

[github-actions[bot]]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.