actual
actual copied to clipboard
Change month picker hover background color
This is just a quick fix for https://github.com/actualbudget/actual/issues/2090. It's my first time contributing to the project so I thought I'd start with something simple.
Deploy Preview for actualbudget ready!
Name | Link |
---|---|
Latest commit | 31d21b6ed5aa991d78e18b576b7d5a3d7764a15b |
Latest deploy log | https://app.netlify.com/sites/actualbudget/deploys/65bbf00eba3a410008ec5744 |
Deploy Preview | https://deploy-preview-2121.demo.actualbudget.org |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Bundle Stats — desktop-client
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
Files count | Total bundle size | % Changed |
---|---|---|
10 | 4.98 MB → 4.98 MB (+5 B) | +0.00% |
Changeset
File | Δ | Size |
---|---|---|
src/components/budget/MonthPicker.tsx |
📈 +5 B (+0.12%) | 4.05 kB → 4.06 kB |
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Asset | File Size | % Changed |
---|---|---|
static/js/wide.js | 239.9 kB → 239.9 kB (+5 B) | +0.00% |
Smaller
No assets were smaller
Unchanged
Asset | File Size | % Changed |
---|---|---|
static/js/resize-observer.js | 18.37 kB | 0% |
static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% |
static/js/BackgroundImage.js | 122.29 kB | 0% |
static/js/ButtonLink.js | 379 B | 0% |
static/js/BalanceTooltip.js | 6.06 kB | 0% |
static/js/FiltersMenu.js | 28.92 kB | 0% |
static/js/narrow.js | 80.18 kB | 0% |
static/js/ReportRouter.js | 1.84 MB | 0% |
static/js/index.js | 2.64 MB | 0% |
Bundle Stats — loot-core
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
Files count | Total bundle size | % Changed |
---|---|---|
1 | 1.18 MB | 0% |
Changeset
No files were changed
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
Asset | File Size | % Changed |
---|---|---|
kcab.worker.js | 1.18 MB | 0% |
Much better, thanks. Can you look at getting the visual regression tests taken care of?
I don't know if you have seen this but it walks through how to update just the snapshots that have changed. https://github.com/actualbudget/actual/tree/master/packages/desktop-client/README.md
I ran the visual regression tests inside the docker container and they all finished successfully. What is the plan of action here?
Also, I think we should change the documentation file you linked.
For instance, I had to use E2E_START_URL=https://192.168.1.79:3001 yarn vrt
to launch the visual regression tests. The URL should be whatever is outputted when the dev server is started.
For instance, I had to use
E2E_START_URL=https://192.168.1.79:3001 yarn vrt
to launch the visual regression tests.
Are you running the test server on a different machine than your local one?
It looks like the screen grabs that you updated don't have anything to do with the change you made. Something must not have run right.
I'm not sure why the github tests are not running, but that may fix itself with a new commit to fix the merge conflicts
Are you running the test server on a different machine than your local one?
I was not. I see you've updated the README.
Also, it seems the last merge commits fixed the issue with the failing tests.