actualbudget
Mobile - Add cleared and uncleared Balances in Account Details
Hello,
thank you for the work at Actual Budget.
I added a small Feature that i personally miss in the mobile View in Account Details.
Maybe it could fit into the regular Build.
Possibly one could make the Balance text a button and toggle it or just show the cleared and uncleared fields, if there are some uncleared transactions.
Thank you!
Deploy Preview for actualbudget ready!
| Name | Link |
|---|---|
| Latest commit | c860d308889897fd225121ef9d65efcecd817165 |
| Latest deploy log | https://app.netlify.com/sites/actualbudget/deploys/659d7a803eacaf000834a7a7 |
| Deploy Preview | https://deploy-preview-2056.demo.actualbudget.org/ |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bundle Stats — desktop-client
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
| Files count | Total bundle size | % Changed |
|---|---|---|
| 15 | 3.08 MB | 0% |
Changeset
No files were changed
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
| Asset | File Size | % Changed |
|---|---|---|
| static/js/main.js | 1.43 MB | 0% |
| static/js/665.chunk.js | 824.28 kB | 0% |
| static/media/Inter-italic.var.woff2 | 239.29 kB | 0% |
| static/media/Inter-roman.var.woff2 | 221.86 kB | 0% |
| static/js/231.chunk.js | 117.38 kB | 0% |
| static/js/wide-components.chunk.js | 112.37 kB | 0% |
| static/js/reports.chunk.js | 77.81 kB | 0% |
| static/js/narrow-components.chunk.js | 43.34 kB | 0% |
| static/js/553.chunk.js | 13.14 kB | 0% |
| static/js/473.chunk.js | 13 kB | 0% |
| static/js/resize-observer-polyfill.chunk.js | 8.88 kB | 0% |
| static/css/main.css | 7.41 kB | 0% |
| asset-manifest.json | 1.92 kB | 0% |
| index.html | 1.66 kB | 0% |
| static/media/browser-server.js | 911 B | 0% |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bundle Stats — loot-core
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
| Files count | Total bundle size | % Changed |
|---|---|---|
| 2 | 2.23 MB | 0% |
Changeset
No files were changed
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
| Asset | File Size | % Changed |
|---|---|---|
| kcab.worker.js | 1.24 MB | 0% |
| xfo.xfo.kcab.worker.js | 1014.45 kB | 0% |
Thank you for taking this on! I think it would feel more visually balanced if the cleared value was on the left and the larger balance text was centered.
Clicking the balance as a button is a good idea to toggle visibility of the other two, but I don't think it would be a show stopper if you didn't implement that.
What if we put this in a modal which shows when the balance amount is clicked? WDYT?
@joel-jeremy Are there additional options or metrics you want to display here? If it's just the two that are shown above, I like the on/off idea for displaying them. If there are more, then I could see possibly moving to a modal as the screen becomes space limited.
Desktop has the order as: Balance, Cleared, Uncleared For consistency I think the mobile version should match.
Cleared value should be colour neutral in my view(same as desktop) as there's nothing about it that needs to draw attention to it. If anything it would be the uncleared value that would be a different colour - but that would be inconsistent with the desktop.
Putting it in a modal is inconsistent with desktop, and also removes the ability to always know how much has or hasn't cleared at a glance. 1 vote for keeping it as a toggle.
I like the idea of clicking the balance to show the details. I don't think I care between total on the left or total in the middle.
Hello,
thank you for your kind feedback.
I am no real professional dev and i am happy that i somehow created something working.
I changed it a little bit, so that the main balance stays centered and the other two are now left and right.
The logic is now as following:
If there are some uncleared transactions, it shows the other two balances. If the uncleared balance is zero, the cleared and the main balance are simply the same. So i think this is the best way giving the user some extra info if necessary and simply hide it if there is no real benefit.
Thank you!
Hi,
i fixed the VRT Problem, so the PR should be ready for review and possibly be merged.
Thank you!
Are there additional options or metrics you want to display here? If it's just the two that are shown above, I like the on/off idea for displaying them. If there are more, then I could see possibly moving to a modal as the screen becomes space limited.
I think we would want to add more account actions in the future such as reconciliation. Having the cleared/uncleared and the reconciliation action in one place would be ideal.
I find the fields useful in the current spot, but I see your point about reconciling. One thought is that if we add a modal for reconciling, we could possibly blur the view behind and redisplay the values in the modal so they're present for that interaction. Another idea could be to add the reconciling more inline, possibly by pressing the account name to expand a larger area for the reconciling buttons.
Hi,
i would love to see this feature in the next release
Is there a problem to merge this request in it's current state?
Thank you
I don't have any issues with it. I'm hoping at least one other person will comment as I don't want to be the lone voice in wanting this feature. There is a merge conflict that needs to be addressed and it likely won't be merged until after the merge freeze if we can find agreement to move forward.
Thanks for your hard work!
I think it's fine as is, assuming the conflicts get cleared up. I still think a toggle on/off would be better and match the desktop view better. That is probably fine as as separate PR though
I think it's fine as is, assuming the conflicts get cleared up. I still think a toggle on/off would be better and match the desktop view better. That is probably fine as as separate PR though
I agree, perhaps get the issue created now and linked back to this to keep track of it?
Hi @shall0pass, @youngcw,
Merge conflict should hopefully be fixed.
Thank you!