actual icon indicating copy to clipboard operation
actual copied to clipboard

[Bug]: Category reorder (drag and drop) does not work when on desktop mode on mobile

Open joel-jeremy opened this issue 1 year ago • 13 comments

Verified issue does not already exist?

  • [X] I have searched and found no existing issue

What happened?

Drag and dropping categories to reorder them does not seem to work when using Chrome on desktop mode in mobile.

What error did you receive?

No response

Where are you hosting Actual?

Fly.io

What browsers are you seeing the problem on?

Chrome

Operating System

Mobile Device

joel-jeremy avatar Jun 26 '23 05:06 joel-jeremy

I am using Safari on mobile. I have it set to 85% zoom. In landscape mode I can reorder categories by drag and drop.

I can also do so using Chrome on iOS.

I therefore wonder if this problem is specific to Android?

Kidglove57 avatar Jun 26 '23 07:06 Kidglove57

Can you try on https://actualbudget.netlify.app/? We recently upgraded our drag and drop library, which may have fixed the issue.

j-f1 avatar Jun 26 '23 11:06 j-f1

I am using an Android phone and I am also encountering the same issue on https://actualbudget.netlify.app/. When trying to drag a category, the category just greys out but does not move.

joel-jeremy avatar Jun 26 '23 14:06 joel-jeremy

Confirmed drop and drag working for me on iPhone using https://actualbudget.netlify.app/, but of course only in landscape mode.

Kidglove57 avatar Jun 26 '23 15:06 Kidglove57

PS it may be relevant that when I said in my earlier post that moving categories was working fine I was using “edge” rather than “latest”.

Kidglove57 avatar Jun 26 '23 15:06 Kidglove57

I'm using v23.6.0. It also doesn't work on both portrait and landscape mode.

joel-jeremy avatar Jun 26 '23 16:06 joel-jeremy

Yes I should have clarified. 23.6.0 but with the latest features included, that have been added since that version (tagged “edge” rather than ”latest” ).

It will be good to hear from any other Android users.

Kidglove57 avatar Jun 26 '23 16:06 Kidglove57

It looks like we may need to use the touch drag-and-drop backend instead of the HTML5 backend on Android. See https://github.com/react-dnd/react-dnd/issues/1660 and https://react-dnd.github.io/react-dnd/docs/backends/touch. I’m not sure what the best way to decide which backend to is — maybe there’s some sort of feature test that could be run? @joel-jeremy since you have a device where it doesn’t work, if you’re willing to figure out a good test for which backend to use that would be much appreciated. (no pressure though!)

j-f1 avatar Jun 26 '23 16:06 j-f1

I could take a stab at it but I'm encountering a lot of linter issues right now with the latest master branch.

joel-jeremy avatar Jun 26 '23 17:06 joel-jeremy

You should be able to ignore the linter errors. If they don’t go away after running yarn install again and including the commit in https://github.com/actualbudget/actual/pull/1199, please ask in discord or open an issue so we can debug further.

j-f1 avatar Jun 26 '23 18:06 j-f1

Including the changes in #1199 fixed the linter errors.

joel-jeremy avatar Jun 26 '23 18:06 joel-jeremy

@MatissJanis Should this be reopened?

joel-jeremy avatar Aug 31 '23 14:08 joel-jeremy

Yes. Thanks for the ping.

MatissJanis avatar Aug 31 '23 16:08 MatissJanis