actual icon indicating copy to clipboard operation
actual copied to clipboard

[Bug]: When adding a new transaction by clicking the on the "Add" button, the payment/deposit amount doesn't get set correctly on the created transaction

Open joel-jeremy opened this issue 1 year ago • 12 comments

Verified issue does not already exist?

  • [X] I have searched and found no existing issue

What happened?

When adding a new transaction by clicking on the Add button, the payment/deposit amount doesn't get set correctly (it's set to 0) on the created transaction.

What error did you receive?

No error but newly creating creating transaction has its amount set to 0.

Where are you hosting Actual?

Fly.io

What browsers are you seeing the problem on?

Chrome

Operating System

Mobile Device

joel-jeremy avatar Jun 25 '23 02:06 joel-jeremy

I am using Safari mobile set to 85% zoom. This does occasionally happen to me but usually the transaction is created with the correct transaction amount. Occasionally I have had a duplicate transaction also created but with 0 amount.

Kidglove57 avatar Jun 26 '23 06:06 Kidglove57

This only seems to be present in mobile not in desktops.

joel-jeremy avatar Jun 28 '23 22:06 joel-jeremy

@joel-jeremy is this on the responsive transaction entry page or the desktop view?

MatissJanis avatar Aug 26 '23 14:08 MatissJanis

I encounter this on the desktop view

joel-jeremy avatar Aug 26 '23 16:08 joel-jeremy

Given we now have mobile transaction entry for mobile users - I'd say this is no longer applicable. What do you think?

MatissJanis avatar Aug 26 '23 16:08 MatissJanis

There's still the problem of split transactions not being implemented in the mobile view yet.

kyrias avatar Aug 26 '23 16:08 kyrias

There's still the problem of split transactions not being implemented in the mobile view yet.

That's a separate issue (please open a new issue). Lets not scope creep.

MatissJanis avatar Aug 26 '23 16:08 MatissJanis

Issue for split transactions in the mobile add transaction view is here: https://github.com/actualbudget/actual/issues/1352

Cldfire avatar Aug 26 '23 16:08 Cldfire

I think we should still address this. Some mobile users might still use desktop view since some desktop features are not yet available in mobile.

joel-jeremy avatar Sep 02 '23 18:09 joel-jeremy

I also run into this. Notes are also not always included. I am using an iPad with iOS 17.2

LarsStegman avatar Jan 06 '24 10:01 LarsStegman

Given we now have mobile transaction entry for mobile users - I'd say this is no longer applicable. What do you think?

It depends what you mean by Mobile if you are talking about hand held devices then you are correct, however iPads are still very much a problem, blank transactions get entered more often than not when creating a new transaction, which I did raise in #2105 I think this needs addressing, it plagues my workflow and really puts me off using the iPad at all for data entry into Actual.

This isn't restricted to iPads though, I am able to replicate the problem in the dev tools on Edge by setting the device to iPad, screenshots below

Steps to replicate

  • Go to accounts register
  • Press add new transaction
  • Complete required fields
  • Fill in payment value
  • Press enter

image

If you press Add again the transaction is added a second time but this time with the value.

image

rich-howell avatar Jan 19 '24 07:01 rich-howell

I looked into the code a little bit and it looks like the field that is in focus does not update its state before the onAdd logic runs, which causes the state to be set to null. Either the field should update its current value constantly or the focus should be removed from the current focussed field before the addTransaction logic is run.

I didn't manage to completely understand how the code works though, so I haven't been be to fix it yet.

LarsStegman avatar Feb 10 '24 19:02 LarsStegman