actual icon indicating copy to clipboard operation
actual copied to clipboard

[Bug]: Scheduled transactions being posted immediately instead of showing up as pending/missed

Open joaociocca opened this issue 1 year ago • 19 comments

Verified issue does not already exist?

  • [X] I have searched and found no existing issue

What happened?

Scheduled transactions show up as upcoming when their date is drawing near, as expected... but when that day arrives, instead of showing up as Pending, or Missed, or whatever is the case, they now get added as if they had been posted.

image

I didn't post this transaction, but it already counts as if it had been. If I manually delete it, it then becomes "missing", as would be expected.

image

But I noticed this happening for a while now - I missed two scheduled transactions around 20th last month, and every time I open the budget I had to find them again and delete them because they were being posted... for a while, they would revert to missing. Last time, already after the month had changed, they didn't revert, they just vanished. It would be nice if they would stay as missing, as expected.

What error did you receive?

No errors

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome, Other

Operating System

Linux

joaociocca avatar May 07 '23 15:05 joaociocca

Do you have the “Automatically add transaction” checkbox checked for that schedule? That will auto-create the schedule.

j-f1 avatar May 07 '23 16:05 j-f1

I agree and understand that it should auto-create the schedule, but at least before (I can't remember if the latest docker update or the previous one) it wouldn't automatically post these transactions, they'd show up as upcoming and when reaching their date or passing them, they'd change from upcoming to missed, until we posted them, as I've been taught in another issue here...

https://github.com/actualbudget/actual/issues/897#issuecomment-1508751809

joaociocca avatar May 07 '23 17:05 joaociocca

I don't have any technical skille to input. However, as a regular user, I do have one weekly schedule that is NOT marked to auto-post. This schedule came around on Friday last. I can confirm that (for me at least) it behaved correctly and did not auto post.

I am using 2023-05.

Kidglove57 avatar May 07 '23 17:05 Kidglove57

Client version: v23.5.0 Server version: v23.5.0

joaociocca avatar May 08 '23 02:05 joaociocca

Yes sorry - I should have written: V23.5.0. Hosted on Fly

Kidglove57 avatar May 08 '23 06:05 Kidglove57

that same transaction I had deleted and had returned to missed status, today is back as posted. image

joaociocca avatar May 08 '23 13:05 joaociocca

If you have the checkbox to auto create transactions checked for the schedule I think that is the expected behavior.

j-f1 avatar May 08 '23 13:05 j-f1

should it be called "auto post transactions" then?

joaociocca avatar May 08 '23 13:05 joaociocca

I thought I would just check the exact "check box" wording that is used when setting up a schedule to be auto posted at each due date.

It is "Automatically add transaction". It seems clear enough for my use but very happy if an alternative wording is clearer to others.

The explanatory note then reads "If checked, the schedule will automatically create transactions for you in the specified account"

Kidglove57 avatar May 08 '23 13:05 Kidglove57

I understand them being two different actions - adding a transaction to the account is one thing, like when it shows as upcoming. Posting being a different one, when you change from upcoming/missed to an actual transaction... but it could be a bug in previous versions that made it behave as I understood, and it wasn't the expected behavior..?

joaociocca avatar May 08 '23 13:05 joaociocca

Thanks for explaining further. I had not thought of it that way. I cannot recall a change in behavior since this was first added to the hosted app a year or two back.

I just created a new scheduled payment, due today, but with the box unticked. The transaction immediately showed as "due" and "greyed out" in my account register but not as "posted". I now have the option to select it and choose"skip scheduled date" or tomorrow it will show as "missed"

Kidglove57 avatar May 08 '23 13:05 Kidglove57

yeah, now that I unchecked automatically add transaction, they show up as expected...

image

Still think this description sounds misleading. But maybe it's just me.

joaociocca avatar May 10 '23 15:05 joaociocca

If you have a better (concise) description we would be happy to change it!

j-f1 avatar May 10 '23 15:05 j-f1

oh great, browser crashed and I lost the post. Let's start again.

Current text goes like this:

image

"Automatically add transaction" and "If checked, the schedule will automatically create transactions for you in the specified account".

To me, this sounds like: the transaction won't be shown in the account screen if this box is unchecked. Something like... it'll be here, in the scheduled screen, to help you keep track of it. But it won't show up over there, in your selected account.

When we go to the account screen, and select an upcoming/due/missed scheduled transaction, the actions shown are:

image

The action that transforms an scheduled transaction into an actual (no pun intended 😅) transaction is "Post transaction". Not "add transaction". And it wouldn't make sense to call it "add transaction", since that's already how it's called including a new one.

If you have a better (concise) description we would be happy to change it!

To answer this directly, I propose changing to: "Automatically post transaction" and "If checked, the schedule will automatically post transactions for you. All scheduled transactions are automatically added in the specified account"

I agree it's not that concise, but it doesn't seem to have a big impact, but explains better the feature:

image

joaociocca avatar May 10 '23 15:05 joaociocca

Just found out I have another beef with the feature. When posting a missed scheduled transaction, it'll post with the original date. But that may kind of get lost in the sea of transactions? Would be nice to have two different actions for it: post on original date, and post today.

joaociocca avatar May 10 '23 18:05 joaociocca

Just found out I have another beef with the feature. When posting a missed scheduled transaction, it'll post with the original date. But that may kind of get lost in the sea of transactions? Would be nice to have two different actions for it: post on original date, and post today.

This should go as a separate issue

rich-howell avatar May 10 '23 18:05 rich-howell

Just found out I have another beef with the feature. When posting a missed scheduled transaction, it'll post with the original date. But that may kind of get lost in the sea of transactions? Would be nice to have two different actions for it: post on original date, and post today.

This should go as a separate issue

#1020

joaociocca avatar May 10 '23 19:05 joaociocca

oh gods, there's more stuff wrong to scheduling and posting. So, I have this transaction that has max due date on the 16th. But I paid for it today. So I posted the upcoming scheduled transaction.

Actual decided that, no matter if it identifies as being part of the schedule (there's the schedule arrows beside it), and despite having been posted from the upcoming transaction, it cloned the upcoming into a new transaction but kept the upcoming transaction there...

image

And on the schedule, it doesn't recognize this as being paid.

image

even the detailed modal is correct and recognizes the transaction as being part of the schedule...

image

joaociocca avatar May 11 '23 01:05 joaociocca

I always looked at the italicized transactions from schedules as future possible entries (but not transactions yet). It's just a preview. If they're automatically entered or manually posted they count towards the account balances and become real entries.

What you're seeing in your last post is the ~4~ 2 day window (https://actualbudget.github.io/docs/Budgeting/schedules#how-actual-finds-schedules) actual looks at to match transactions to a schedule. Since you posted a transaction and then changed the date to 6 days early, you're no longer in the window and it won't match to the schedule. I know it's by design, but I'm not sure what the reasoning was.

I wouldn't say anything is necessarily broken. It's just not probably what you're used to.

shall0pass avatar May 11 '23 01:05 shall0pass

I have to agree with @shall0pass that this works as-expected.

Closing this off since the original issue is no-op.

MatissJanis avatar Aug 26 '23 14:08 MatissJanis