fix: limit external-eic-shell error reports to downstream use only

Open wdconinc opened this issue 3 weeks ago • 4 comments

Limit the types of errors that external-eic-shell reports in the summary to build errors after ACTS has been successfully built, and treat failure to build ACTS itself as a pipeline error.

--- END COMMIT MESSAGE ---

With the notifications of failures in the external-eic-shell stack, we now also receive notifications of code in PR that is not yet ready where ACTS fails to compile (rather than this being a change in interface that EIC needs to be aware of). This is not actionable for EIC, so the notifications are noise. Example is https://github.com/acts-project/acts/actions/runs/20168575581/job/57898016435

This PR modifies the strategy to treat build failures of ACTS within the EIC environment as a primary error that will fail a pipeline (instead of only reporting a failure in the comment). This is unlikely to suppress true EIC-specific issues, which would be cases where ACTS builds fine, but somehow the EIC environment can't build it.

Dec 12 '25 15:12 wdconinc

@tmadlener Maybe you want something like this for key4hep builds?

Dec 12 '25 16:12 wdconinc

📊: Physics performance monitoring for 5f9511eaa0482aaa47d8ca5b6cd6a42ed918e371

Full contents

physmon summary

Dec 12 '25 16:12 github-actions[bot]

RFR @paulgessinger Does this seem like something you'd be ok with? It opens a risk in that the ACTS build itself can build in all ACTS testing systems but fail inside the EIC environment. That's currently not a hard failure, but would become one.

Dec 12 '25 18:12 wdconinc

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Dec 12 '25 18:12 sonarqubecloud[bot]