acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor: Make the MagneticFieldContext & GeometryContext to be hard types

Open junggjo9 opened this issue 1 year ago • 7 comments

Instead of using make them classes @paulgessinger, @andiwand

junggjo9 avatar Jul 03 '24 15:07 junggjo9

Can you also do it for the calibration context?

paulgessinger avatar Jul 03 '24 15:07 paulgessinger

Si. Are there any other contexts as well?

junggjo9 avatar Jul 03 '24 15:07 junggjo9

I think that's it

paulgessinger avatar Jul 03 '24 18:07 paulgessinger

is this breaking @paulgessinger ?

andiwand avatar Jul 04 '24 08:07 andiwand

I'll trigger an Athena build when I have a patch ready for #3337. Can we hold off on merging this until we know it's breaking?

paulgessinger avatar Jul 04 '24 08:07 paulgessinger

The SEGFAULT masks the actual error message (which is due to DD4hep interference I believe):

>       mmAlgCfg = MaterialMapping.Config(context.geoContext, context.magFieldContext)
E       TypeError: Unable to convert function return value to a Python type! The signature was
E               (self: acts.ActsPythonBindings._examples.AlgorithmContext) -> Acts::MagneticFieldContext

Examples/Scripts/Python/material_mapping.py:75: TypeError

Does that help @junggjo9?

paulgessinger avatar Jul 11 '24 13:07 paulgessinger

Thanks for that hint @paulgessinger. I did not find that in the logs and was not able to catch the signal.

andiwand avatar Jul 16 '24 16:07 andiwand

Merging manually due to transient docs failure.

paulgessinger avatar Jul 17 '24 10:07 paulgessinger

:red_circle: Athena integration test results [bf5545e6e65cee01923aaa886927c4d7a84727ad]

:red_circle: Some tests have failed!

Please investigate the pipeline!

status job report
:red_circle: run_unit_tests
:green_circle: report_pull_request
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco
:green_circle: test_ActsDumpGeometryIdentifiers
:green_circle: test_ActsCheckObjectCountsWorkflow
:red_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:red_circle: test_ActsWorkflowCached
:red_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:red_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:red_circle: run_workflow_tests_run4_mc
:red_circle: run_workflow_tests_run2_mc
:red_circle: run_workflow_tests_run2_data
:red_circle: run_workflow_tests_run3_mc
:red_circle: run_workflow_tests_run3_data

acts-project-service avatar Jul 17 '24 13:07 acts-project-service