acts icon indicating copy to clipboard operation
acts copied to clipboard

feat: Select space points used to fill the seeding grid via delegate function. Add experimentCuts support

Open pbutti opened this issue 1 year ago • 2 comments

This PR aims introduces a delegate function to the SeedFinderConfig to select space points that should be used to fill the grid before the doublet search. The reason for this PR is to allow custom cuts, such as the one done in ATHENA FastTracking chain (see https://acode-browser.usatlas.bnl.gov/lxr/source/athena/Tracking/Acts/ActsPatternRecognition/src/SeedingAlg.cxx#0129) without introducing misalignments in the indexing of the space points that would reflect in issues in storing information in the Acts::SpacePointData class.

The PR also adds 2 functions to the SeedingAlgorithm that reflect the cuts used in Athena FastTracking chain so the effect and parameter optimization could be done in ACTS if wanted. Other experiments could also check the SeedingAlgorithm for inspiration for their own selection.

pbutti avatar Jul 02 '24 12:07 pbutti

very minor comment that for sure clang will complain about

CarloVarni avatar Jul 02 '24 13:07 CarloVarni

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 25%)
0.0% Line Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jul 09 '24 13:07 sonarqubecloud[bot]

can you force merge this @paulgessinger ? sonarcloud is not happy

andiwand avatar Jul 09 '24 15:07 andiwand

Done

paulgessinger avatar Jul 09 '24 15:07 paulgessinger

:white_check_mark: Athena integration test results [57c632e2fa00d5fcb4a24887c1cb9dea6a0a2404]

:white_check_mark: All tests successful

status job report
:green_circle: report_pull_request
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco
:green_circle: test_ActsDumpGeometryIdentifiers
:green_circle: test_ActsCheckObjectCountsWorkflow
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflowCached
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_unit_tests

acts-project-service avatar Jul 10 '24 09:07 acts-project-service