feat: Select space points used to fill the seeding grid via delegate function. Add experimentCuts support
This PR aims introduces a delegate function to the SeedFinderConfig to select space points that should be used to fill the grid before the doublet search. The reason for this PR is to allow custom cuts, such as the one done in ATHENA FastTracking chain (see https://acode-browser.usatlas.bnl.gov/lxr/source/athena/Tracking/Acts/ActsPatternRecognition/src/SeedingAlg.cxx#0129) without introducing misalignments in the indexing of the space points that would reflect in issues in storing information in the Acts::SpacePointData class.
The PR also adds 2 functions to the SeedingAlgorithm that reflect the cuts used in Athena FastTracking chain so the effect and parameter optimization could be done in ACTS if wanted. Other experiments could also check the SeedingAlgorithm for inspiration for their own selection.
very minor comment that for sure clang will complain about
📊: Physics performance monitoring for 0a7af509610223fcec0e5531d51a7292af15a0ca
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- ✅ Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4
Quality Gate failed
Failed conditions
0.0% Coverage on New Code (required ≥ 25%)
0.0% Line Coverage on New Code (required ≥ 50%)
can you force merge this @paulgessinger ? sonarcloud is not happy
Done