fix(gx2f): use all states for `jacobianFromStart`
Since we also set the jacobians for holes-states, we need to multiply those in.
Looking at the implementation of the GX2F we only call transportCovarianceToBound here https://github.com/acts-project/acts/blob/02de894a2513ce1488011e9d6ab8447b83b75afb/Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp#L445 which indicates to me that the jacobians for holes are not generated and stored. Looking at the hole implementation we are explicitly skipping the cov transport there https://github.com/acts-project/acts/blob/02de894a2513ce1488011e9d6ab8447b83b75afb/Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp#L566C36-L566C46
📊: Physics performance monitoring for 016084dfddaab53eb64d07685590f9f15ba3db5d
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- 🔴 Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
Project coverage is 47.42%. Comparing base (
55e6ede) to head (016084d). Report is 519 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp | 0.00% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #3274 +/- ##
=======================================
Coverage 47.41% 47.42%
=======================================
Files 511 511
Lines 30225 30225
Branches 14659 14659
=======================================
+ Hits 14332 14333 +1
+ Misses 5362 5361 -1
Partials 10531 10531
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
- Flaky Tests Detection - Detect and resolve failed and flaky tests
Will be handled clearer in
- https://github.com/acts-project/acts/pull/3551