acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor: Remove target volume estimation from `Navigator`

Open andiwand opened this issue 1 year ago • 2 comments

This is https://github.com/acts-project/acts/pull/3217 after it was reverted with https://github.com/acts-project/acts/pull/3241. There were a couple of failures monitored in Athena which could not be fixed right away.

This is an attempt to remove (IMO) unnecessary complexity from the Navigator. We have a target volume estimation which runs a couple of times to guess the target volume based on an intersection with the target surface. IMO if we know the target surface we should also know the target volume and the user is responsible for passing this information.

andiwand avatar Jun 01 '24 07:06 andiwand

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.62%. Comparing base (360fc15) to head (2b63ec9). Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3242      +/-   ##
==========================================
- Coverage   47.65%   47.62%   -0.04%     
==========================================
  Files         507      507              
  Lines       29207    29167      -40     
  Branches    14012    13986      -26     
==========================================
- Hits        13918    13890      -28     
- Misses       5265     5272       +7     
+ Partials    10024    10005      -19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 01 '24 07:06 codecov[bot]

📊: Physics performance monitoring for 26a9f1218f7401b964152d932cb13d218eb8f98c

Full contents

physmon summary

github-actions[bot] avatar Jun 01 '24 08:06 github-actions[bot]

:white_check_mark: Athena integration test results [ba521200fce09c3a32e11b41f4f237fe27c6aaf2]

:white_check_mark: All tests successful

status job report
:green_circle: report_pull_request
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco
:green_circle: test_ActsDumpGeometryIdentifiers
:green_circle: test_ActsCheckObjectCountsCachedWorkflow
:green_circle: test_ActsCheckObjectCountsWorkflow
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflowCached
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_unit_tests

acts-project-service avatar Aug 07 '24 06:08 acts-project-service