refactor: Remove target volume estimation from `Navigator`
This is https://github.com/acts-project/acts/pull/3217 after it was reverted with https://github.com/acts-project/acts/pull/3241. There were a couple of failures monitored in Athena which could not be fixed right away.
This is an attempt to remove (IMO) unnecessary complexity from the Navigator. We have a target volume estimation which runs a couple of times to guess the target volume based on an intersection with the target surface. IMO if we know the target surface we should also know the target volume and the user is responsible for passing this information.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 47.62%. Comparing base (
360fc15) to head (2b63ec9). Report is 73 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3242 +/- ##
==========================================
- Coverage 47.65% 47.62% -0.04%
==========================================
Files 507 507
Lines 29207 29167 -40
Branches 14012 13986 -26
==========================================
- Hits 13918 13890 -28
- Misses 5265 5272 +7
+ Partials 10024 10005 -19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
📊: Physics performance monitoring for 26a9f1218f7401b964152d932cb13d218eb8f98c
physmon summary
- ✅ Particles fatras
- ✅ Particles geant4
- ✅ Particles ttbar
- ✅ Vertices ttbar
- ✅ Truth tracking (KF)
- ✅ Truth tracking (GSF)
- ✅ Truth tracking (GX2F)
- ✅ CKF | trackfinding | single muon | truth smeared seeding
- ✅ Track Summary CKF | trackfinding | single muon | truth smeared seeding
- ✅ Seeding trackfinding | single muon | truth estimated seeding
- ✅ CKF | trackfinding | single muon | truth estimated seeding
- ✅ Track Summary CKF | trackfinding | single muon | truth estimated seeding
- ✅ Seeding trackfinding | single muon | default seeding
- ✅ CKF | trackfinding | single muon | default seeding
- ✅ Track Summary CKF | trackfinding | single muon | default seeding
- ✅ Seeding trackfinding | single muon | orthogonal seeding
- ✅ CKF | trackfinding | single muon | orthogonal seeding
- ✅ Track Summary CKF | trackfinding | single muon | orthogonal seeding
- ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
- ✅ CKF | trackfinding | 4 muon x 50 vertices | default seeding
- ✅ Track Summary CKF | trackfinding | 4 muon x 50 vertices | default seeding
- ✅ Ambisolver | trackfinding | 4 muon x 50 vertices | default seeding
- ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
- ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
- ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
- ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
- ✅ CKF | trackfinding | ttbar with 200 pileup | default seeding
- ✅ Track Summary CKF | trackfinding | ttbar with 200 pileup | default seeding
- ✅ Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
- ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
- ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding
:white_check_mark: Athena integration test results [ba521200fce09c3a32e11b41f4f237fe27c6aaf2]
:white_check_mark: All tests successful
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
61.1% Coverage on New Code
0.0% Duplication on New Code