refactor: Remove `lastHierarchySurfaceReached` from `Navigator`

[andiwand]

This is a leftover from previous PRs which cleaned out the Navigator

[github-actions[bot]]

📊: Physics performance monitoring for 11453f2957f5b45f9bb2dbe691fc82cc2ed574e5

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.36%. Comparing base (d8f615f) to head (4663a6f). Report is 121 commits behind head on main.

Files	Patch %	Lines
Core/include/Acts/Propagator/Navigator.hpp	50.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
- Coverage   47.59%   47.36%   -0.24%     
==========================================
  Files         507      511       +4     
  Lines       29137    30257    +1120     
  Branches    13976    14679     +703     
==========================================
+ Hits        13869    14332     +463     
- Misses       5269     5388     +119     
- Partials     9999    10537     +538     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[andiwand]

I will update the ref since the flag was dealing with a different kind of navigation I suppose the new output is more meaningful

[acts-project-service]

:red_circle: Athena integration test results [3d85e3c22ff61064c6452ee3e4c75db868fa1b51]

:red_circle: Some tests have failed!

Please investigate the pipeline!

status	job	report
:green_circle:	report_pull_request
:green_circle:	run_art_test: test_data18_13TeV_1000evt
:green_circle:	run_art_test: test_ttbarPU40_reco
:green_circle:	test_ActsDumpGeometryIdentifiers
:red_circle:	test_ActsCheckObjectCountsCachedWorkflow
:red_circle:	test_ActsCheckObjectCountsWorkflow
:green_circle:	test_ActsEFTrackFit
:green_circle:	test_ActsPersistifySeeds
:green_circle:	test_ActsBenchmarkWithSpot
:red_circle:	test_ActsAnalogueClustering
:red_circle:	test_ActsWorkflowHeavyIons
:red_circle:	test_ActsWorkflowFastTracking
:red_circle:	test_ActsWorkflowCached
:red_circle:	test_ActsWorkflow
:green_circle:	test_ActsValidateAmbiguityResolution
:red_circle:	test_ActsValidateResolvedTracks
:red_circle:	test_ActsValidateTracks
:green_circle:	test_ActsValidateActsCoreSpacePoints
:green_circle:	test_ActsValidateActsSpacePoints
:green_circle:	test_ActsValidateSeeds
:green_circle:	test_ActsValidateOrthogonalSeeds
:green_circle:	test_ActsValidateClusters
:red_circle:	test_ActsPersistifyEDM
:green_circle:	test_ActsGSFRefitting
:green_circle:	test_ActsKfRefitting
:green_circle:	test_ActsExtrapolationAlgTest
:green_circle:	test_ActsITkTest
:green_circle:	run_workflow_tests_run4_mc
:green_circle:	run_workflow_tests_run2_mc
:green_circle:	run_workflow_tests_run2_data
:green_circle:	run_workflow_tests_run3_mc
:green_circle:	run_workflow_tests_run3_data
:green_circle:	run_unit_tests

[andiwand]

Still failing - this might be something specific about the ITk geometry. I will try to reproduce this in the standalone outside Athena. Very weird

[andiwand]

There are some count changes in Athena. I will change the reference on the canary as soon as this goes in

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud