acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor: Use Core CKF extrapolation after inwards extension

Open andiwand opened this issue 1 year ago • 1 comments

After changes in the Core CKF we are now able to use the extrapolated parameters from within the CKF and don't need to redo the work.

Pulled out of https://github.com/acts-project/acts/pull/3188 to capture the reference change and the performance

blocked by

  • https://github.com/acts-project/acts/pull/3161

andiwand avatar May 16 '24 11:05 andiwand

image

andiwand avatar Jul 25 '24 11:07 andiwand

The ITk ttbar_pu200 efficiency etc are not significantly changed by this PR. I can't speak to the resolutions. However I do see a 4.7% speedup :)

It's a long time since I looked into it, but would it be a big addition to add the performance analysis plots (where we can check resolutions) to the full_chain*.py tests? I think many people trying out ACTS could benefit from more detailed results.

ATLAS can test this out in Athena, so I guess it's not a top priority for us.

timadye avatar Jul 30 '24 11:07 timadye

It's a long time since I looked into it, but would it be a big addition to add the performance analysis plots (where we can check resolutions) to the full_chain*.py tests? I think many people trying out ACTS could benefit from more detailed results.

I think that makes sense yeah - I am reworking the root outputting a bit which somehow ended up at the very end of my current list of tasks but generally I would like to have finder and fitter performance for the CKF instead of "CKF performance" and track summary.

andiwand avatar Jul 30 '24 11:07 andiwand

:red_circle: Athena integration test results [555e6cea1786f1b2f64aa6703b4d1262fcd40402]

:red_circle: Some tests have failed!

Please investigate the pipeline!

status job report
:green_circle: report_pull_request
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco
:green_circle: test_ActsDumpGeometryIdentifiers
:red_circle: test_ActsCheckObjectCountsCachedWorkflow
:red_circle: test_ActsCheckObjectCountsWorkflow
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflowCached
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_unit_tests

acts-project-service avatar Jul 30 '24 16:07 acts-project-service