acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor!: Template on track container frontend `TrackContainer`

Open andiwand opened this issue 1 year ago • 2 comments

blocked by

  • https://github.com/acts-project/acts/pull/3192

andiwand avatar May 16 '24 08:05 andiwand

📊: Physics performance monitoring for 1bbfb643f2f2d11cea1439bbd3f7f97d5bb9d8d4

Full contents

physmon summary

github-actions[bot] avatar May 16 '24 13:05 github-actions[bot]

My primary reason was to break the template param dependency chain a bit. For example the fitters / finder / ambi res should not have to carry through the holder type and the mutability flag.

Concepts would be great here I think! In principle the user should be able to create their own high level track container and proxy objects. Not sure if this is useful but I think the decoupling would be nice.

I think this one is actually not critical at all for v36 btw. I am happy to push this a bit further if we cannot make it until we want to cut the major release.

andiwand avatar Jun 05 '24 14:06 andiwand

Yes I think that would make it solid. Will do

andiwand avatar Jul 23 '24 08:07 andiwand

This still has some CI failures, and unfortunately also picked up conflicts now. Can you fix them @andiwand ?

paulgessinger avatar Aug 06 '24 19:08 paulgessinger

:white_check_mark: Athena integration test results [1e855a2fdf06ab7834d83b08eb08869dd011ae1a]

:white_check_mark: All tests successful

status job report
:green_circle: report_pull_request
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco
:green_circle: test_ActsDumpGeometryIdentifiers
:green_circle: test_ActsCheckObjectCountsCachedWorkflow
:green_circle: test_ActsCheckObjectCountsWorkflow
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflowCached
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_unit_tests

acts-project-service avatar Sep 03 '24 09:09 acts-project-service