acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor!: Track EDM brush over

Open andiwand opened this issue 1 year ago • 6 comments

  • use calibrated instead of measurement
  • expose typedefs
  • correct index params

andiwand avatar May 16 '24 08:05 andiwand

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 47.65%. Comparing base (cf9d872) to head (c8ce9be). Report is 17 commits behind head on main.

:exclamation: Current head c8ce9be differs from pull request most recent head 304e582

Please upload reports for the commit 304e582 to get more accurate results.

Files Patch % Lines
...e/include/Acts/EventData/VectorMultiTrajectory.hpp 40.00% 3 Missing and 3 partials :warning:
Core/src/TrackFitting/GainMatrixUpdater.cpp 0.00% 0 Missing and 1 partial :warning:
Core/src/TrackFitting/GsfUtils.cpp 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3192      +/-   ##
==========================================
+ Coverage   47.24%   47.65%   +0.41%     
==========================================
  Files         508      507       -1     
  Lines       30041    29207     -834     
  Branches    14586    14012     -574     
==========================================
- Hits        14192    13918     -274     
+ Misses       5375     5265     -110     
+ Partials    10474    10024     -450     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 03 '24 14:06 codecov[bot]

:red_circle: Athena integration test results [fa78ed3e938361d9e615f2b7421e330276b36bac]

Build job with this PR failed!

Please investigate the build job for the pipeline!

acts-project-service avatar Jun 24 '24 13:06 acts-project-service

I guess it does in fact break Athena compilation, doesn't it?

paulgessinger avatar Jul 01 '24 15:07 paulgessinger

I guess it does in fact break Athena compilation, doesn't it?

Yes I think at least the measurement -> calibrated method name change will break Athena. I can patch this tomorrow before we eventually merge this

andiwand avatar Jul 01 '24 16:07 andiwand

This seems to break with rootcling in the Athena build e.g. https://gitlab.cern.ch/acts/acts-athena-ci/-/jobs/40986739

Most likely because root is picking the wrong ACTS headers which are not compatible with the changes here.

Maybe we just merge this PR as the last one for v36 or directly before a new nightly is triggered

cc @paulgessinger

andiwand avatar Jul 09 '24 10:07 andiwand