refactor!: Track EDM brush over
- use
calibratedinstead ofmeasurement - expose typedefs
- correct index params
📊: Physics performance monitoring for 3dba00e009145f43754cca1a7a446a2ee39cf081
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- ✅ Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4
Codecov Report
Attention: Patch coverage is 75.00000% with 8 lines in your changes missing coverage. Please review.
Project coverage is 47.65%. Comparing base (
cf9d872) to head (c8ce9be). Report is 17 commits behind head on main.
:exclamation: Current head c8ce9be differs from pull request most recent head 304e582
Please upload reports for the commit 304e582 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## main #3192 +/- ##
==========================================
+ Coverage 47.24% 47.65% +0.41%
==========================================
Files 508 507 -1
Lines 30041 29207 -834
Branches 14586 14012 -574
==========================================
- Hits 14192 13918 -274
+ Misses 5375 5265 -110
+ Partials 10474 10024 -450
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:red_circle: Athena integration test results [fa78ed3e938361d9e615f2b7421e330276b36bac]
Build job with this PR failed!
I guess it does in fact break Athena compilation, doesn't it?
I guess it does in fact break Athena compilation, doesn't it?
Yes I think at least the measurement -> calibrated method name change will break Athena. I can patch this tomorrow before we eventually merge this
This seems to break with rootcling in the Athena build e.g. https://gitlab.cern.ch/acts/acts-athena-ci/-/jobs/40986739
Most likely because root is picking the wrong ACTS headers which are not compatible with the changes here.
Maybe we just merge this PR as the last one for v36 or directly before a new nightly is triggered
cc @paulgessinger
Quality Gate passed
Issues
0 New issues
4 Accepted issues
Measures
0 Security Hotspots
68.5% Coverage on New Code
0.0% Duplication on New Code