acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor!: Move `Navigator` external surfaces into options

Open andiwand opened this issue 1 year ago • 2 comments

blocked by

  • https://github.com/acts-project/acts/pull/3181
  • https://github.com/acts-project/acts/pull/3182
  • https://github.com/acts-project/acts/pull/3190

andiwand avatar May 15 '24 08:05 andiwand

Codecov Report

Attention: Patch coverage is 66.91729% with 44 lines in your changes missing coverage. Please review.

Project coverage is 47.62%. Comparing base (75ef913) to head (ae3d31a). Report is 79 commits behind head on main.

Files Patch % Lines
Core/include/Acts/TrackFitting/KalmanFitter.hpp 38.46% 0 Missing and 8 partials :warning:
...lude/Acts/Propagator/DenseEnvironmentExtension.hpp 0.00% 0 Missing and 6 partials :warning:
Core/include/Acts/Propagator/DirectNavigator.hpp 72.22% 0 Missing and 5 partials :warning:
Core/include/Acts/Propagator/Navigator.hpp 66.66% 0 Missing and 5 partials :warning:
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 0.00% 4 Missing and 1 partial :warning:
Core/include/Acts/Propagator/PropagatorOptions.hpp 77.77% 0 Missing and 4 partials :warning:
Core/include/Acts/Propagator/PropagatorState.hpp 40.00% 0 Missing and 3 partials :warning:
Core/include/Acts/Propagator/EigenStepper.ipp 50.00% 2 Missing :warning:
Core/include/Acts/Propagator/AtlasStepper.hpp 50.00% 0 Missing and 1 partial :warning:
Core/include/Acts/Propagator/TryAllNavigator.hpp 85.71% 0 Missing and 1 partial :warning:
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3189      +/-   ##
==========================================
- Coverage   47.66%   47.62%   -0.04%     
==========================================
  Files         509      511       +2     
  Lines       29425    29421       -4     
  Branches    14131    14138       +7     
==========================================
- Hits        14026    14013      -13     
+ Misses       5285     5284       -1     
- Partials    10114    10124      +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 08 '24 16:06 codecov[bot]

Docs job failure is due to imagemagick.com being down. I'm merging manually.

paulgessinger avatar Jul 17 '24 06:07 paulgessinger

:red_circle: Athena integration test results [8054963b0355226b8443d2d7a3048efd148604ac]

:red_circle: Some tests have failed!

Please investigate the pipeline!

status job report
:green_circle: report_pull_request
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco
:green_circle: test_ActsDumpGeometryIdentifiers
:green_circle: test_ActsCheckObjectCountsWorkflow
:green_circle: test_ActsEFTrackFit
:red_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflowCached
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_unit_tests

acts-project-service avatar Jul 17 '24 09:07 acts-project-service