acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor!: Refactor direct navigator initialization

Open andiwand opened this issue 1 year ago • 2 comments

blocked by:

  • https://github.com/acts-project/acts/pull/3181
  • https://github.com/acts-project/acts/pull/3182
  • https://github.com/acts-project/acts/pull/3190

andiwand avatar May 10 '24 12:05 andiwand

Codecov Report

Attention: Patch coverage is 68.48485% with 52 lines in your changes missing coverage. Please review.

Project coverage is 47.66%. Comparing base (75ef913) to head (cabfe79). Report is 77 commits behind head on main.

Files Patch % Lines
Core/include/Acts/Propagator/DirectNavigator.hpp 65.00% 4 Missing and 17 partials :warning:
...lude/Acts/Propagator/DenseEnvironmentExtension.hpp 0.00% 0 Missing and 6 partials :warning:
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 0.00% 4 Missing and 1 partial :warning:
Core/include/Acts/TrackFitting/KalmanFitter.hpp 54.54% 0 Missing and 5 partials :warning:
Core/include/Acts/Propagator/PropagatorOptions.hpp 77.77% 0 Missing and 4 partials :warning:
Core/include/Acts/Propagator/PropagatorState.hpp 40.00% 0 Missing and 3 partials :warning:
Core/include/Acts/Propagator/EigenStepper.ipp 50.00% 2 Missing :warning:
Core/include/Acts/Propagator/AtlasStepper.hpp 50.00% 0 Missing and 1 partial :warning:
Core/include/Acts/Propagator/Navigator.hpp 88.88% 0 Missing and 1 partial :warning:
Core/include/Acts/Propagator/TryAllNavigator.hpp 85.71% 0 Missing and 1 partial :warning:
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3183      +/-   ##
==========================================
- Coverage   47.66%   47.66%   -0.01%     
==========================================
  Files         509      511       +2     
  Lines       29425    29421       -4     
  Branches    14131    14131              
==========================================
- Hits        14026    14023       -3     
+ Misses       5285     5281       -4     
- Partials    10114    10117       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 08 '24 16:06 codecov[bot]

:red_circle: Athena integration test results [918b4641eaa6aed9a2be6e3bccf74de1ea6a57a8]

Build job with this PR failed!

Please investigate the build job for the pipeline!

acts-project-service avatar Jul 16 '24 18:07 acts-project-service