acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor!: Refactor navigator options

Open andiwand opened this issue 1 year ago • 2 comments

blocked by:

  • https://github.com/acts-project/acts/pull/3181
  • https://github.com/acts-project/acts/pull/3190

andiwand avatar May 10 '24 12:05 andiwand

Codecov Report

Attention: Patch coverage is 71.54472% with 35 lines in your changes missing coverage. Please review.

Project coverage is 47.66%. Comparing base (75ef913) to head (e8fe116). Report is 77 commits behind head on main.

Files Patch % Lines
...lude/Acts/Propagator/DenseEnvironmentExtension.hpp 0.00% 0 Missing and 6 partials :warning:
Core/include/Acts/Propagator/DirectNavigator.hpp 72.22% 0 Missing and 5 partials :warning:
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 0.00% 4 Missing and 1 partial :warning:
Core/include/Acts/TrackFitting/KalmanFitter.hpp 54.54% 0 Missing and 5 partials :warning:
Core/include/Acts/Propagator/PropagatorOptions.hpp 83.33% 0 Missing and 3 partials :warning:
Core/include/Acts/Propagator/PropagatorState.hpp 40.00% 0 Missing and 3 partials :warning:
Core/include/Acts/Propagator/EigenStepper.ipp 50.00% 2 Missing :warning:
Core/include/Acts/Propagator/AtlasStepper.hpp 50.00% 0 Missing and 1 partial :warning:
Core/include/Acts/Propagator/Navigator.hpp 88.88% 0 Missing and 1 partial :warning:
Core/include/Acts/Propagator/TryAllNavigator.hpp 85.71% 0 Missing and 1 partial :warning:
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3182      +/-   ##
==========================================
- Coverage   47.66%   47.66%   -0.01%     
==========================================
  Files         509      511       +2     
  Lines       29425    29425              
  Branches    14131    14133       +2     
==========================================
- Hits        14026    14025       -1     
+ Misses       5285     5282       -3     
- Partials    10114    10118       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 08 '24 16:06 codecov[bot]

:white_check_mark: Athena integration test results [3b8ea138d3e37279027b23c5443a9e83c718969d]

:white_check_mark: All tests successful

status job report
:green_circle: report_pull_request
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco
:green_circle: test_ActsDumpGeometryIdentifiers
:green_circle: test_ActsCheckObjectCountsWorkflow
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflowCached
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_unit_tests

acts-project-service avatar Jul 15 '24 22:07 acts-project-service