acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor!: Split propagator options

Open andiwand opened this issue 1 year ago • 3 comments

Currently our propagator options cannot communicate stepper or navigator specific options which would come handy for example for the DirectNavigator to communicate the surface sequence before starting the propagation.

Summary of the changes in this PR

  • Split propagator options into Stepper, Navigator and Propagator options
  • Introduce StepperPlainOptions and NavigatorPlainOptions
  • Make PropagatorPlainOptions dependent on StepperPlainOptions and NavigatorPlainOptions
  • Handle downstream changes

andiwand avatar May 09 '24 11:05 andiwand

Codecov Report

Attention: Patch coverage is 68.75000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 47.64%. Comparing base (75ef913) to head (6125a2f).

Files Patch % Lines
...lude/Acts/Propagator/DenseEnvironmentExtension.hpp 0.00% 0 Missing and 6 partials :warning:
Core/include/Acts/Propagator/PropagatorOptions.hpp 82.35% 0 Missing and 3 partials :warning:
Core/include/Acts/Propagator/PropagatorState.hpp 40.00% 0 Missing and 3 partials :warning:
Core/include/Acts/Propagator/EigenStepper.ipp 50.00% 2 Missing :warning:
Core/include/Acts/TrackFitting/KalmanFitter.hpp 33.33% 0 Missing and 2 partials :warning:
Core/include/Acts/Propagator/AtlasStepper.hpp 50.00% 0 Missing and 1 partial :warning:
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 0.00% 0 Missing and 1 partial :warning:
Core/src/Material/SurfaceMaterialMapper.cpp 0.00% 1 Missing :warning:
Core/src/Material/VolumeMaterialMapper.cpp 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3181      +/-   ##
==========================================
- Coverage   47.66%   47.64%   -0.02%     
==========================================
  Files         509      511       +2     
  Lines       29425    29418       -7     
  Branches    14131    14133       +2     
==========================================
- Hits        14026    14017       -9     
  Misses       5285     5285              
- Partials    10114    10116       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 09:05 codecov[bot]

in case there are more sonarcloud issues I will follow that up in one of the sacked PRs

andiwand avatar Jul 12 '24 12:07 andiwand

:white_check_mark: Athena integration test results [7db63a6c394976b59511f74cccd1d0e91cddbabb]

:white_check_mark: All tests successful

status job report
:green_circle: report_pull_request
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco
:green_circle: test_ActsDumpGeometryIdentifiers
:green_circle: test_ActsCheckObjectCountsWorkflow
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflowCached
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_unit_tests

acts-project-service avatar Jul 12 '24 19:07 acts-project-service