acts icon indicating copy to clipboard operation
acts copied to clipboard

feat: material mapper in core (MM4)

Open asalzburger opened this issue 10 months ago • 2 comments

This is the first PR in a series that divides the Material Mapping into logical, unit testable modules:

  1. Finding intersections with surfaces and associations to volumes (MM2)
  2. Assigning material interactions to those intersections (MM1)
  3. Mapping those onto dedicated Surface / Volume Material Mappers (MM3)
  4. Steer that by a chained algorithm (MM4, this PR)

This PR:

Introduces a MaterialMapper which just needs I/O connection in the relevant framework/experiment context implementation.

All cases are showcased and tested in a set of UnitTests.

asalzburger avatar Apr 08 '24 15:04 asalzburger

Hey @Corentin-Allaire - this one is pretty small now.

asalzburger avatar Apr 09 '24 12:04 asalzburger

Looks good ! Is the plan to add the volume part later ?

Yes, I will finish the surface part first, and try to make it fully reproduce what we had before.

asalzburger avatar Apr 10 '24 13:04 asalzburger

:white_check_mark: Athena integration test results [21cbbf749f9171a7616d9c9210506be7a8d83f05]

:white_check_mark: All tests successful

status job report
:green_circle: run_unit_tests
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsConversionWorkflow
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco

acts-project-service avatar Apr 10 '24 18:04 acts-project-service