acts
acts copied to clipboard
acts-project
refactor: rewrite measurement selector
Changes to improve the measurement selector
/cc @andiwand and @goetzgaycken
First changes from a quick look. Will do more later (that is why this is a draft for now)
Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 49.02%. Comparing base (
1374baa) to head (f67393d). Report is 5 commits behind head on main.
:exclamation: Current head f67393d differs from pull request most recent head 7e63e63. Consider uploading reports for the commit 7e63e63 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| Core/src/TrackFinding/MeasurementSelector.cpp | 0.00% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #3083 +/- ##
=======================================
Coverage 49.02% 49.02%
=======================================
Files 494 494
Lines 29058 29059 +1
Branches 13797 13797
=======================================
+ Hits 14246 14247 +1
Misses 4929 4929
Partials 9883 9883
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
📊: Physics performance monitoring for 7e63e63fb4cf7872975a56ff3d63e6bc9c7cb562
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- ✅ Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@andiwand of course @paulgessinger was correct about the map types, so I reverted the changes on passing by reference for those.
I have applied additional changed to the function but I'm afraid this is not coming with an executing time improvement. I still think the new function is cleaner and easier to understand, so I'd like to push it anyway into ACTS
