refactor: add output format option in material_mapping.py
add a command line option to specify map name and format in json or cbor
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 47.65%. Comparing base (
e433c95) to head (692f0ba). Report is 278 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3071 +/- ##
=======================================
Coverage 47.65% 47.65%
=======================================
Files 507 507
Lines 29207 29207
Branches 14012 14012
=======================================
Hits 13918 13918
Misses 5265 5265
Partials 10024 10024
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
📊: Physics performance monitoring for 692f0bac17a81d08c7c8afdb7497428e337247a8
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- ✅ Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4
To get rid of the python-formatting error in the CI: https://acts.readthedocs.io/en/latest/contribution/run_formatting.html#python-formatting
Thanks. The code passed the check with black locally.
That is odd. I get:
$ black material_mapping.py
reformatted material_mapping.py
All done! ✨ 🍰 ✨
1 file reformatted.
Could you check again?
That is odd. I get:
$ black material_mapping.py reformatted material_mapping.py All done! ✨ 🍰 ✨ 1 file reformatted.Could you check again?
OK I apparently didn't push the reformatted version. It should be good now.
@paulgessinger sorry to bother you - could you add @ShujieL to the CI Bridge users?
@andiwand @ShujieL Invite sent.
@andiwand @ShujieL Invite sent.
@paulgessinger I didn't receive any notification. Can you resend?
@paulgessinger @andiwand just wanted to follow up. I didn't get any github notification on "CI bridge". Is that why this PR is stuck?
@paulgessinger can we get CI Bridge permissions for @ShujieL ?