acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor: add output format option in material_mapping.py

Open ShujieL opened this issue 1 year ago • 5 comments

add a command line option to specify map name and format in json or cbor

ShujieL avatar Apr 02 '24 21:04 ShujieL

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.65%. Comparing base (e433c95) to head (692f0ba). Report is 278 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3071   +/-   ##
=======================================
  Coverage   47.65%   47.65%           
=======================================
  Files         507      507           
  Lines       29207    29207           
  Branches    14012    14012           
=======================================
  Hits        13918    13918           
  Misses       5265     5265           
  Partials    10024    10024           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 03 '24 08:04 codecov[bot]

To get rid of the python-formatting error in the CI: https://acts.readthedocs.io/en/latest/contribution/run_formatting.html#python-formatting

Thanks. The code passed the check with black locally.

ShujieL avatar Apr 05 '24 03:04 ShujieL

That is odd. I get:

$ black material_mapping.py 
reformatted material_mapping.py

All done! ✨ 🍰 ✨
1 file reformatted.

Could you check again?

AJPfleger avatar Apr 05 '24 09:04 AJPfleger

That is odd. I get:

$ black material_mapping.py 
reformatted material_mapping.py

All done! ✨ 🍰 ✨
1 file reformatted.

Could you check again?

OK I apparently didn't push the reformatted version. It should be good now.

ShujieL avatar Apr 05 '24 17:04 ShujieL

@paulgessinger sorry to bother you - could you add @ShujieL to the CI Bridge users?

andiwand avatar Apr 09 '24 18:04 andiwand

@andiwand @ShujieL Invite sent.

paulgessinger avatar Apr 10 '24 07:04 paulgessinger

@andiwand @ShujieL Invite sent.

@paulgessinger I didn't receive any notification. Can you resend?

ShujieL avatar Apr 22 '24 10:04 ShujieL

@paulgessinger @andiwand just wanted to follow up. I didn't get any github notification on "CI bridge". Is that why this PR is stuck?

ShujieL avatar May 30 '24 18:05 ShujieL

@paulgessinger can we get CI Bridge permissions for @ShujieL ?

andiwand avatar May 30 '24 18:05 andiwand

:white_check_mark: Athena integration test results [360fc152b007fda7d48a3f74fa9f9d8431f51ee4]

:white_check_mark: All tests successful

status job report
:green_circle: run_unit_tests
:green_circle: test_ActsCheckObjectCountsWorkflow
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsWorkflowHeavyIons
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflowCached
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco

acts-project-service avatar Jun 01 '24 09:06 acts-project-service