acts
acts copied to clipboard
acts-project
feat: Add ability to store particle status and do it for Geant4
Another quality of life improvement for the simulation chain. There is currently no way to know the status of a particle. I implemented it for G4 based on why a particle is killed - I'm open for suggestions if enum values could be improved.
Note that this touches the particle definition in the ACTS Fatras API, but it just adds a member variable and does not remove anything so it's not a breaking change.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 48.99%. Comparing base (
3203649) to head (5e109fa). Report is 28 commits behind head on main.
:exclamation: Current head 5e109fa differs from pull request most recent head 27c37d9. Consider uploading reports for the commit 27c37d9 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #3068 +/- ##
==========================================
- Coverage 49.09% 48.99% -0.11%
==========================================
Files 497 490 -7
Lines 29155 28996 -159
Branches 13851 13743 -108
==========================================
- Hits 14314 14206 -108
- Misses 4908 4951 +43
+ Partials 9933 9839 -94
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
📊: Physics performance monitoring for 27c37d97da3b59ffbf715e59119e1928b2fcef21
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- ✅ Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ntadej could you update the references?
- physmon output can be found here https://github.com/acts-project/acts/actions/runs/8703154667/artifacts/1417672409
- you can overwrite the changed files in
CI/physmon/reference
- you can overwrite the changed files in
- new hashes at the bottom here https://github.com/acts-project/acts/actions/runs/8703154667/job/23869530759?pr=3068
- you can update the changed hashes manually or with
CI/merge_hashes.py. the reference is inExamples/Python/tests/root_file_hashes.txt
- you can update the changed hashes manually or with
Hmm, I think we hit some irreproducibility, probably because all values for Fatras are 0 and then compression messes-up something. I updated the hash twice now and it's different each time.
