acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor: TrackingVolume and Volume interface + functionality

Open paulgessinger opened this issue 1 year ago • 2 comments

This PR:

  • Marks all of the Gen1 interface of TrackingVolume as such, to indicate what we'll supersede in the future
  • Makes a slight adjustment to TransformRange, for
  • Add internal vector of uniquely owned child TrackingVolumes in TrackingVolume, accessible in a const-preserving way through TransformRange.
  • Updates the TrackingVolume constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3

Blocked by:

  • #3060

paulgessinger avatar Mar 27 '24 16:03 paulgessinger

Codecov Report

Attention: Patch coverage is 55.55556% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 49.12%. Comparing base (bdf9ae1) to head (f729bce).

:exclamation: Current head f729bce differs from pull request most recent head a8c8a10. Consider uploading reports for the commit a8c8a10 to get more accurate results

Files Patch % Lines
Core/src/Geometry/Volume.cpp 42.10% 9 Missing and 2 partials :warning:
Core/src/Geometry/TrackingVolume.cpp 66.66% 4 Missing and 2 partials :warning:
Core/include/Acts/Geometry/TrackingVolume.hpp 50.00% 0 Missing and 1 partial :warning:
Core/src/Geometry/CuboidVolumeBuilder.cpp 50.00% 0 Missing and 1 partial :warning:
Core/src/Geometry/CylinderVolumeHelper.cpp 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3064      +/-   ##
==========================================
+ Coverage   49.10%   49.12%   +0.02%     
==========================================
  Files         501      501              
  Lines       29295    29244      -51     
  Branches    13906    13862      -44     
==========================================
- Hits        14385    14367      -18     
- Misses       4956     4957       +1     
+ Partials     9954     9920      -34     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 27 '24 16:03 codecov[bot]

:white_check_mark: Athena integration test results [12b861157bab5bbecccdac3c6a847c4c6eb75bcd]

:white_check_mark: All tests successful

status job report
:green_circle: run_unit_tests
:green_circle: test_ActsEFTrackFit
:green_circle: test_ActsPersistifySeeds
:green_circle: test_ActsBenchmarkWithSpot
:green_circle: test_ActsAnalogueClustering
:green_circle: test_ActsConversionWorkflow
:green_circle: test_ActsWorkflowFastTracking
:green_circle: test_ActsWorkflow
:green_circle: test_ActsValidateAmbiguityResolution
:green_circle: test_ActsValidateResolvedTracks
:green_circle: test_ActsValidateTracks
:green_circle: test_ActsValidateActsCoreSpacePoints
:green_circle: test_ActsValidateActsSpacePoints
:green_circle: test_ActsValidateSeeds
:green_circle: test_ActsValidateOrthogonalSeeds
:green_circle: test_ActsValidateClusters
:green_circle: test_ActsPersistifyEDM
:green_circle: test_ActsGSFRefitting
:green_circle: test_ActsKfRefitting
:green_circle: test_ActsExtrapolationAlgTest
:green_circle: test_ActsITkTest
:green_circle: run_workflow_tests_run4_mc
:green_circle: run_workflow_tests_run2_mc
:green_circle: run_workflow_tests_run2_data
:green_circle: run_workflow_tests_run3_mc
:green_circle: run_workflow_tests_run3_data
:green_circle: run_art_test: test_data18_13TeV_1000evt
:green_circle: run_art_test: test_ttbarPU40_reco

acts-project-service avatar Apr 24 '24 00:04 acts-project-service