acts
acts copied to clipboard
refactor: TrackingVolume and Volume interface + functionality
This PR:
- Marks all of the Gen1 interface of
TrackingVolumeas such, to indicate what we'll supersede in the future - Makes a slight adjustment to
TransformRange, for - Add internal vector of uniquely owned child
TrackingVolumes inTrackingVolume, accessible in a const-preserving way throughTransformRange. - Updates the
TrackingVolumeconstructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3
Blocked by:
- #3060
Codecov Report
Attention: Patch coverage is 55.55556% with 20 lines in your changes are missing coverage. Please review.
Project coverage is 49.12%. Comparing base (
bdf9ae1) to head (f729bce).
:exclamation: Current head f729bce differs from pull request most recent head a8c8a10. Consider uploading reports for the commit a8c8a10 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #3064 +/- ##
==========================================
+ Coverage 49.10% 49.12% +0.02%
==========================================
Files 501 501
Lines 29295 29244 -51
Branches 13906 13862 -44
==========================================
- Hits 14385 14367 -18
- Misses 4956 4957 +1
+ Partials 9954 9920 -34
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
📊: Physics performance monitoring for a8c8a10d7bb22aeda9ab0685d9c2e44ee90b37db
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- ✅ Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4