acts icon indicating copy to clipboard operation
acts copied to clipboard

feat: Geometry agnostic space point maker

Open Alonl14 opened this issue 1 year ago • 3 comments

Within the Examples Module, Implementing a space point maker that is agnostic to the geometry object used i.e. TrackingGeometry / Detector.

Alonl14 avatar Jan 23 '24 17:01 Alonl14

Added @Alonl14 to the CI perms group.

paulgessinger avatar Jan 24 '24 11:01 paulgessinger

Hi @Alonl14 - can you, as a start, add a description what this PR should do for reference ?

asalzburger avatar Jan 24 '24 12:01 asalzburger

Codecov Report

Attention: Patch coverage is 62.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 48.90%. Comparing base (9b2fd7d) to head (2af394d). Report is 286 commits behind head on main.

:exclamation: Current head 2af394d differs from pull request most recent head ef977e4

Please upload reports for the commit ef977e4 to get more accurate results.

Files Patch % Lines
Core/src/Surfaces/SurfaceContainer.cpp 27.27% 6 Missing and 2 partials :warning:
...e/include/Acts/EventData/detail/TestSourceLink.hpp 72.72% 1 Missing and 5 partials :warning:
Core/include/Acts/Surfaces/SurfaceContainer.hpp 85.71% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2890      +/-   ##
==========================================
- Coverage   48.94%   48.90%   -0.05%     
==========================================
  Files         496      496              
  Lines       28913    28851      -62     
  Branches    13710    13681      -29     
==========================================
- Hits        14151    14109      -42     
- Misses       4878     4881       +3     
+ Partials     9884     9861      -23     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 25 '24 12:01 codecov[bot]

archiving this due to inactivity for now

andiwand avatar Aug 31 '24 07:08 andiwand