acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor: Physmon in pytest

Open paulgessinger opened this issue 1 year ago • 5 comments

This PR proposes reimplementing the physmon workflows inside pytest, where tests are defined to run the workflows. This also allows me to define most of the extra steps, like file output comparisons and file existence checks can be orchestrated via python functions. This also allows me to provide a unified way to provide a local reference directory like

pytest -k "physmon" -v --physmon-reference-path local_references

and also to automatically update the references like

pytest -k "physmon" -v --physmon-update-references

The two can also be combined, which is nice!

paulgessinger avatar Oct 24 '23 14:10 paulgessinger

Draft for now, to gather feedback before potentially adding the other workflows.

What do you think @andiwand @benjaminhuth ?

paulgessinger avatar Oct 24 '23 14:10 paulgessinger

I like it! I wonder if this should ultimately also go into Examples/Python/tests? we could either separate it by folders or mark the tests differently. at the end of the day all of these are higher level integration tests I feel like

andiwand avatar Oct 24 '23 14:10 andiwand

@andiwand Ultimately, I don't think it matters from a technical standpoint, only from an organizational one.

paulgessinger avatar Oct 24 '23 14:10 paulgessinger

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.85%. Comparing base (adccec3) to head (795e7b2). Report is 511 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2575      +/-   ##
==========================================
- Coverage   49.64%   48.85%   -0.80%     
==========================================
  Files         471      483      +12     
  Lines       26632    28146    +1514     
  Branches    12237    13270    +1033     
==========================================
+ Hits        13222    13750     +528     
- Misses       4742     4818      +76     
- Partials     8668     9578     +910     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 24 '23 15:10 codecov[bot]

I'll need to revisit this another time.

paulgessinger avatar Jun 21 '24 06:06 paulgessinger