acts
acts copied to clipboard
acts-project
feat!: Space point implementation
Read-only implementation of the space point EDM, following the examples from Tracks and MTJ. The seeding infrastructures have been adapted to this, both the default and orthogonal seeding.
This also removed the following classes: InternalSpacePoint and InternalSeed
Hi Carlo, I think this is what we want. From what I looked at the code there may be few missing pieces (to be able to build this container). And I have some technical questions/doubts.
this now needs both https://github.com/acts-project/acts/pull/1948 and https://github.com/acts-project/acts/pull/1966
This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
still a lot of work to do here, but the basic structure is in place. @paulgessinger @tboldagh can you take a look at this?
Codecov Report
Attention: Patch coverage is 11.50895% with 346 lines in your changes missing coverage. Please review.
Project coverage is 48.71%. Comparing base (
d8e46ff) to head (bad00ac). Report is 374 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1900 +/- ##
==========================================
- Coverage 48.90% 48.71% -0.19%
==========================================
Files 491 498 +7
Lines 28561 28691 +130
Branches 13487 13569 +82
==========================================
+ Hits 13967 13978 +11
- Misses 4861 4980 +119
Partials 9733 9733
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
📊: Physics performance monitoring for 3583c9e1c8e0d8956da9d6305598dad4f9606542
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Particles ttbar
- ✅ Vertices ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- ✅ Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
/cc-ing the experts @LuisFelipeCoelho @noemina @paulgessinger @stephenswat @tboldagh
I propose to still keep this open. This has gone down in the priority list. I'd like to apply possibly a couple of changes to the Seed Finder and grid creation before.
Quality Gate failed
Failed conditions
0.5% Coverage on New Code (required ≥ 25%)
11 New Bugs (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
0.83% Line Coverage on New Code (required ≥ 50%)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension 
SonarLint
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}