acts icon indicating copy to clipboard operation
acts copied to clipboard

refactor: Remove dependency on Boost::program_options from Algorithms/Writers/Readers

Open benjaminhuth opened this issue 3 years ago • 4 comments

This aims to be the first step into making the binaries optional to build by removing the dependencies on Boost::program_options from the Algorithms/Writers/Readers.

The second step would be to also unwind this from the Detectors, but this is a bit more complicated, and thus I would do this step by step.

A long term goal would be that only the Analysis Apps depend on Boost program options, so that just building the Examples does not need any Boost components that require binaries (since we also use std::filesystem now).

benjaminhuth avatar Oct 20 '22 17:10 benjaminhuth

Codecov Report

Merging #1610 (f503cfe) into main (08b9e91) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1610   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         381      381           
  Lines       20776    20776           
  Branches     9517     9517           
=======================================
  Hits        10110    10110           
  Misses       4095     4095           
  Partials     6571     6571           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 20 '22 18:10 codecov[bot]

@benjaminhuth do you want feedback now already or not yet?

paulgessinger avatar Oct 21 '22 07:10 paulgessinger

If you have some general feedback, go ahead. I think feedback on implementation details should wait until this compiles

benjaminhuth avatar Oct 21 '22 07:10 benjaminhuth

I think I've cleaned this up, if the CI goes through could you have a look again @paulgessinger ?

benjaminhuth avatar Oct 24 '22 16:10 benjaminhuth

:bar_chart: Physics performance monitoring for f503cfeba09136d12a87e87b57159c400d4f5310

Full report CKF: seeded, truth smeared, truth estimated IVF: seeded, truth smeared, truth estimated Ambiguity resolution Truth tracking

Vertexing

IVF seeded

IVF truth smeared

IVF truth estimated

CKF

seeded

truth smeared

truth estimated

Ambiguity resolution

seeded

Truth tracking

Truth tracking

github-actions[bot] avatar Oct 25 '22 07:10 github-actions[bot]

@paulgessinger the CI is running through now :)

benjaminhuth avatar Oct 25 '22 09:10 benjaminhuth