acts icon indicating copy to clipboard operation
acts copied to clipboard

feat: GX2F (Global Chi2 Fitter) | Gχ²F

Open AJPfleger opened this issue 3 years ago • 1 comments

A clean PR for the GX2F. This is the completion of PR #1099 since, some segfaults on mac were causing problems (read there for more info on that issue).

The GX2F consists now of:

  • core algorithm Chi2Fitter.hpp
  • simple UnitTest

AJPfleger avatar Oct 06 '22 14:10 AJPfleger

Codecov Report

Merging #1580 (2adbe34) into main (ec15a62) will decrease coverage by 0.04%. The diff coverage is 31.73%.

@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
- Coverage   48.58%   48.54%   -0.05%     
==========================================
  Files         381      384       +3     
  Lines       20833    21041     +208     
  Branches     9557     9693     +136     
==========================================
+ Hits        10122    10214      +92     
+ Misses       4108     4105       -3     
- Partials     6603     6722     +119     
Impacted Files Coverage Δ
Core/src/TrackFitting/Chi2FitterError.cpp 0.00% <0.00%> (ø)
Core/include/Acts/TrackFitting/Chi2Fitter.hpp 32.98% <32.98%> (ø)
...de/Acts/TrackFitting/detail/VoidChi2Components.hpp 50.00% <50.00%> (ø)
Core/include/Acts/Propagator/Navigator.hpp 55.65% <0.00%> (+0.88%) :arrow_up:
Core/include/Acts/Propagator/ConstrainedStep.hpp 72.34% <0.00%> (+2.12%) :arrow_up:
Core/src/Utilities/Logger.cpp 39.13% <0.00%> (+8.69%) :arrow_up:
Core/src/Definitions/Common.cpp 32.00% <0.00%> (+32.00%) :arrow_up:
Core/include/Acts/Surfaces/Surface.hpp 66.66% <0.00%> (+33.33%) :arrow_up:
Core/src/Surfaces/RectangleBounds.cpp 86.66% <0.00%> (+53.33%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 06 '22 14:10 codecov[bot]

:bar_chart: Physics performance monitoring for 083474a17baf66ddac3a5dfe4f11827812ef43df

Full report CKF: seeded, truth smeared, truth estimated IVF: seeded, truth smeared, truth estimated Ambiguity resolution Truth tracking

Vertexing

IVF seeded

IVF truth smeared

IVF truth estimated

CKF

seeded

truth smeared

truth estimated

Ambiguity resolution

seeded

Truth tracking

Truth tracking

github-actions[bot] avatar Oct 26 '22 09:10 github-actions[bot]

I'll merge this manually when the CI completes, so we can properly add a reference to @r4lv in the commit.

paulgessinger avatar Nov 01 '22 16:11 paulgessinger