acts icon indicating copy to clipboard operation
acts copied to clipboard

fix: Set s_binningValues as const

Open CarloVarni opened this issue 2 years ago • 1 comments

Setting s_binningValues as const as well. The Atlas Thread-check is complaining about this since it suspect this may be not thread safe.

CarloVarni avatar Sep 01 '22 20:09 CarloVarni

Codecov Report

Merging #1485 (facbe51) into main (42b16ef) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1485   +/-   ##
=======================================
  Coverage   48.60%   48.60%           
=======================================
  Files         380      380           
  Lines       20595    20595           
  Branches     9433     9433           
=======================================
  Hits        10010    10010           
  Misses       4097     4097           
  Partials     6488     6488           
Impacted Files Coverage Δ
Core/include/Acts/Utilities/BinningType.hpp 66.66% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 01 '22 21:09 codecov[bot]

CI bridge refused because @CarloVarni is not on the allowlist yet. I'm merging this manually.

paulgessinger avatar Sep 02 '22 07:09 paulgessinger

The backport to develop/v19.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-develop/v19.x develop/v19.x
# Navigate to the new working tree
cd .worktrees/backport-develop/v19.x
# Create a new branch
git switch --create backport-1485-to-develop/v19.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b172918b0cb02d910faabc534e8db2069c27e78a
# Push it to GitHub
git push --set-upstream origin backport-1485-to-develop/v19.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-develop/v19.x

Then, create a pull request where the base branch is develop/v19.x and the compare/head branch is backport-1485-to-develop/v19.x.

acts-project-service avatar Sep 02 '22 07:09 acts-project-service