acts
acts copied to clipboard
feat: check if yOuter takes the square root of a negative number when minHelixRadius < rMax / 2 in SpacePointGrid.ipp
This PR adds a check to SpacePointGrid.ipp
if minHelixRadius
is smaller than config.rMax / 2
as suggested in #1456.
This happens if rMax
of the grid in mm
is greater than 2 x pT[GeV] / (3·10-4 × B[T])
. I am not sure if this combination of parameters makes sense in one specific detector configuration.
@robertlangenberg
Codecov Report
Merging #1466 (39df28e) into main (b172918) will decrease coverage by
0.00%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #1466 +/- ##
==========================================
- Coverage 48.60% 48.59% -0.01%
==========================================
Files 380 380
Lines 20595 20597 +2
Branches 9433 9435 +2
==========================================
Hits 10010 10010
- Misses 4097 4099 +2
Partials 6488 6488
Impacted Files | Coverage Δ | |
---|---|---|
Core/include/Acts/Seeding/SpacePointGrid.ipp | 0.00% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more