acton icon indicating copy to clipboard operation
acton copied to clipboard

Backend tests leave processes open on MacOS

Open sydow opened this issue 2 years ago • 1 comments

Acton Version

0.15.0.20230530.12.21.57

Steps to Reproduce

ps -a make test ps -a

Expected Behavior

Acton tests run, succeed and leave no open processes

Actual Behavior

acton> ps -a PID TTY TIME CMD 482 ttys000 0:00.01 login -pfl sydow /bin/bash -c exec -la bash /bin/bash 486 ttys000 0:00.40 -bash 18326 ttys000 0:00.00 ps -a acton> make test ... A lot of outputabout successful tests ... ... /Users/sydow/acton/dist/bin/actonc --quiet --always-build --dev rts_db/ddb_test_server.act /Users/sydow/acton/dist/bin/actonc --quiet --always-build --dev rts_db/ddb_test_client.act /Users/sydow/acton/dist/bin/actonc --quiet --always-build --dev rts_db/test_tcp_client.act rts_db/test_tcp_client Test success! acton> ps -a PID TTY TIME CMD 482 ttys000 0:00.01 login -pfl sydow /bin/bash -c exec -la bash /bin/bash 486 ttys000 0:00.41 -bash 20227 ttys000 0:00.01 ../dist/bin/actondb -p 13702 20228 ttys000 0:00.01 ../dist/bin/actondb -p 13704 20245 ttys000 0:00.01 ../dist/bin/actondb -p 18260 -s 127.0.0.1 20246 ttys000 0:00.01 ../dist/bin/actondb -p 18262 -s 127.0.0.1 20247 ttys000 0:00.01 ../dist/bin/actondb -p 18264 -s 127.0.0.1 20273 ttys000 0:00.01 ./rts_db/ddb_test_server 23019 --rts-verbose 20274 ttys000 0:00.01 ../dist/bin/actondb -p 22820 20275 ttys000 0:00.01 ../dist/bin/actondb -p 22822 20276 ttys000 0:00.01 ../dist/bin/actondb -p 22824 20278 ttys000 0:00.00 ps -a acton>

sydow avatar May 30 '23 10:05 sydow

It happens on Linux too. I am going to guess and say this is somewhere in libuv / our process module where we don't properly clean up after ourselves. The process module should, per default, kill children when the acton application exist.

plajjan avatar May 30 '23 12:05 plajjan