actix icon indicating copy to clipboard operation
actix copied to clipboard

fix: Forward `poll_ready()` errors to the actor and possibly finish

Open sdroege opened this issue 1 year ago • 3 comments

PR Type

Bug Fix

PR Checklist

Check your PR fulfills the following:

  • [ ] Tests for the changes have been added / updated.
  • [x] Documentation comments have been added / updated.
  • [ ] A changelog entry has been made for the appropriate packages.
  • [x] Format code with the latest stable rustfmt

Overview

It's not generally supported to poll a Sink again after it returned an error anywhere, and e.g. SinkMapErr from the futures crate is simply panicking if this happens.


cc @gdesmott

sdroege avatar Dec 09 '24 10:12 sdroege

Could you contrive a test that would fail on master ?

robjtede avatar Dec 10 '24 11:12 robjtede

Yes, if this approach makes sense and you don't want to solve the underlying problem (which AFAICS requires breaking API changes)

sdroege avatar Dec 10 '24 11:12 sdroege

To make progress, this PR needs a test and a changelog entry.

robjtede avatar Feb 23 '25 19:02 robjtede