actix-web icon indicating copy to clipboard operation
actix-web copied to clipboard

Strip non-address characters from Forwarded for=

Open mpalmer opened this issue 1 year ago • 0 comments
trafficstars

PR Type

Bug Fix

PR Checklist

  • [x] Tests for the changes have been added / updated.
  • [x] Documentation comments have been added / updated.
  • [x] A changelog entry has been made for the appropriate packages.
  • [x] Format code with the latest stable rustfmt.
  • [ ] (Team) Label with affected crates and semver status.

Overview

This is something of a followup to #2528, which asked for port information to not be included in when it was taken from the local socket.

The header's element may optionally contain port information (https://datatracker.ietf.org/doc/html/rfc7239#section-6). However, as I understand it, is supposed to only contain an IP address, without port (per #2528).

This PR corrects that discrepancy, making it easier to parse the result of this method in application code.

There should not be any compatibility concerns, as anyone parsing the output of would already need to handle both port and portless cases anyway.

mpalmer avatar Apr 26 '24 07:04 mpalmer