actix-web icon indicating copy to clipboard operation
actix-web copied to clipboard

fix pending stream drop

Open simorex80 opened this issue 3 years ago • 5 comments

PR Type

But Fix

PR Checklist

  • [x] ~Tests for the changes have been added / updated.~
  • [x] Documentation comments have been added / updated.
  • [x] A changelog entry has been made for the appropriate packages.
  • [x] Format code with the latest stable rustfmt.
  • [x] (Team) Label with affected crates and semver status.

Overview

Fix the problem described in bug: A Stream object in a pending state won't be dropped after the client disconnect https://github.com/actix/actix-web/issues/1313 When the disconnection events is triggered, no state check is needed. The streaming process, due no access to TcpStream, don't have the necessary elements to change the state and this caused the stuck described in the bug.

Closes #1313

simorex80 avatar Aug 07 '22 23:08 simorex80

Any ideas when this PR might be closed/merged?

vlvicente avatar Jun 05 '23 15:06 vlvicente

It's waiting on a test case demonstrating the fix.

robjtede avatar Jun 05 '23 17:06 robjtede

It's needed something from my side?

Il lun 5 giu 2023, 19:45 Rob Ede @.***> ha scritto:

It's waiting on a test case demonstrating the fix.

— Reply to this email directly, view it on GitHub https://github.com/actix/actix-web/pull/2830#issuecomment-1577215600, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATXPXPHTPTKEFBODMCDEAJ3XJYLLVANCNFSM553IGQJQ . You are receiving this because you authored the thread.Message ID: @.***>

simorex80 avatar Jun 05 '23 18:06 simorex80

It's needed something from my side? Il lun 5 giu 2023, 19:45 Rob Ede @.***> ha scritto:

The test case demonstrating the fix, I'm guessing!

vlvicente avatar Jun 06 '23 15:06 vlvicente

Any update on this?

wangyoucao577 avatar Jul 29 '23 06:07 wangyoucao577