actix-net icon indicating copy to clipboard operation
actix-net copied to clipboard

Add a builder for arbiter + alive method

Open Sytten opened this issue 1 year ago • 5 comments

PR Type

Feature

PR Checklist

Check your PR fulfills the following:

  • [x] Tests for the changes have been added / updated.
  • [x] Documentation comments have been added / updated.
  • [x] A changelog entry has been made for the appropriate packages.
  • [x] Format code with the latest stable rustfmt

Overview

Builder

This adds a builder for the arbiter, allowing more customization of the thread used by the arbiter.

The first customizable I added was the name, this allows us to differentiate the different arbiters better since they are not all used for the same purpose.

Alive

I also added an alive method on the arbiter so the caller can try to detect dead arbiters before sending it a future since it consumes it. Otherwise you need to have a clone future which is not good most of the time.

Sytten avatar May 09 '24 18:05 Sytten

LGTM from a quick look but needs a manual rebase (which I don't have perms to do on this PR).

robjtede avatar May 14 '24 03:05 robjtede

@robjtede Sorry it took forever to rebase, its done

Sytten avatar Oct 28 '24 02:10 Sytten

drafting due to staleness and CI failures

robjtede avatar May 09 '25 18:05 robjtede

@robjtede I will try to rebase, but lets try to merge it this time XD

Sytten avatar May 09 '25 19:05 Sytten

@Sytten sure, i just generally don't have time to review PRs where "Linux / Stable" is failing as it did last time

robjtede avatar May 24 '25 07:05 robjtede